Bug 593108

+++ This bug was initially created as a clone of Bug #506587 +++

Description of problem: When using an lvm resource with a volume group name that is a substring of the nodename or another volume group, the lvm resource agent will fail to start that resource.  For example if the resource is:

  <lvm lv_name="ext3-a" name="mysql-lv" vg_name="clust">

And the volume_list is:

  volume_list = [ "VolGroup00", "@jrummy5-1-clust.ruemker.pvt" ]

Since the vg_name (clust) is a substring of the nodename, it produces this error:

# rg_test test /etc/cluster/cluster.conf start service mysql-server
Running in test mode.
Starting mysql-server...
[...]
  volume_list=["VolGroup00", "@jrummy5-1-clust.ruemker.pvt"]
  volume_list=["VolGroup00", "@jrummy5-1-clust.ruemker.pvt"]
<err>    HA LVM:  Improper setup detected
<err>    - clust found in "volume_list" in lvm.conf

This is caused by 

        if lvm dumpconfig activation/volume_list | grep "\"$OCF_RESKEY_vg_name\""; then
                ocf_log err "HA LVM:  Improper setup detected"
                ocf_log err "- $OCF_RESKEY_vg_name found in \"volume_list\" in lvm.conf"
                return $OCF_ERR_GENERIC
        fi

Since entries in the volume_list must be in quotes anyways, there is an easy way to fix this:

--- /usr/share/cluster/lvm.sh.orig	2009-06-17 16:33:21.000000000 -0400
+++ /usr/share/cluster/lvm.sh	2009-06-17 16:33:54.000000000 -0400
@@ -79,7 +79,7 @@ function ha_lvm_proper_setup_check
 	# lvm.conf:activation/volume_list; otherwise, machines
 	# will be able to activate the VG regardless of the tags
 	##
-	if lvm dumpconfig activation/volume_list | grep $OCF_RESKEY_vg_name; then
+	if lvm dumpconfig activation/volume_list | grep "\"$OCF_RESKEY_vg_name\""; then
 		ocf_log err "HA LVM:  Improper setup detected"
 		ocf_log err "- $OCF_RESKEY_vg_name found in \"volume_list\" in lvm.conf"
 		return $OCF_ERR_GENERIC

I realize this situation may be kind of rare, but I'm betting I'm not the only person who uses the word cluster or clust in both the hostnames and volume group name.  

Version-Release number of selected component (if applicable): rgmanager-2.0.46-1.el5

How reproducible: Always

Steps to Reproduce:
1. Configure an lvm resource where the volume group name is a substring of the node name that is in the volume_list in /etc/lvm/lvm.conf
2. Start the service
  
Actual results: Service fails to start

Expected results: Service starts

--- Additional comment from jruemker on 2009-06-17 16:44:47 EDT ---

Oops.  The code snippet I pasted was actually my patched version.  I meant to say This is caused by:

       if lvm dumpconfig activation/volume_list | grep
$OCF_RESKEY_vg_name; then
                ocf_log err "HA LVM:  Improper setup detected"
                ocf_log err "- $OCF_RESKEY_vg_name found in \"volume_list\" in
lvm.conf"
                return $OCF_ERR_GENERIC
        fi

--- Additional comment from jbrassow on 2010-05-14 16:14:49 EDT ---

Patch pulled in to rhel5 tree