Bug 593274
| Summary: | Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-will_paginate-2.3.12-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-21 16:36:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 459892 | ||
| Bug Blocks: | |||
|
Description
Michal Fojtik
2010-05-18 12:04:44 UTC
*** Bug 539268 has been marked as a duplicate of this bug. *** Will review (In reply to comment #2) > Will review Thanks ! :) Well,
* Documents
- It is better that test/ directory is marked as %doc
( I usually also mark Rakefile as %doc )
* Macros in %changelog
- Use %% instead of % to avoid unexpanded macro expansion in %changelog.
* Requires
- lib/will_paginate.rb contains:
------------------------------------------------------------
1 require 'active_support'
2 require 'will_paginate/core_ext'
------------------------------------------------------------
So at least this should have "Requires: rubygem(activesupport)".
Thanks Mamoru, Updated files: Spec URL: http://mifo.sk/RPMS/rubygem-will_paginate.spec SRPM URL: http://mifo.sk/RPMS/rubygem-will_paginate-2.3.12-2.fc13.src.rpm Okay. -------------------------------------------------------------------- This package (rubygem-will_paginame) is APPROVED by mtasaka -------------------------------------------------------------------- .... rubygem-will_paginate is approved. New Package CVS Request ======================= Package Name: rubygem-xml-simple Short Description: A simple API for XML processing Owners: mfojtik Branches: F-11 F-12 F-13 F-14 EL-5 I'm apologize for wrong package name. Correct one: New Package CVS Request ======================= Package Name: rubygem-will_paginate Short Description: Most awesome pagination solution for Rails Owners: mfojtik Branches: F-11 F-12 F-13 F-14 EL-5 CVS done (by process-cvs-requests.py). rubygem-will_paginate-2.3.12-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc11 rubygem-will_paginate-2.3.12-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc12 rubygem-will_paginate-2.3.12-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc13 Actually, EL-5 is blocked by rubygem-mocha. I contacted maintainer of this package and requested a build for EL-5. I'll build this package for this branch as soon as this dependency will be included in updates. Closing (as this package is built on Fedora branches and updates were submitted) rubygem-will_paginate-2.3.12-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-will_paginate-2.3.12-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-will_paginate-2.3.12-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |