Bug 593565

Summary: libvirt doesn't sanitize pool target paths, causes issues with virt-manager
Product: Red Hat Enterprise Linux 6 Reporter: Nan Zhang <nzhang>
Component: libvirtAssignee: Cole Robinson <crobinso>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: low    
Version: 6.0CC: dallan, eli, hbrock, llim, mjenner, syeghiay, xen-maint
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-0_8_1-8_el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-11 14:49:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Sanitize pool target paths (mail message, misplaced the original patch!) none

Description Nan Zhang 2010-05-19 07:17:35 UTC 
Description of problem:
As summary.

Version-Release number of selected component (if applicable):
virt-manager-0.8.4-2.el6.noarch
libvirt-0.8.1-4.el6.x86_64
python-virtinst-0.500.3-2.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a pool named 'VirtualMachines', path to '/var/lib/libvirt/images/',
and set the state with 'Active'.
2. Create a new VM, and proceeding to the dialog of disk image creation. 
3. Hit the 'Browse' button and manually create a storage volume.
4. Choosing created volume and hit 'Forward'.
  
Actual results:
Popup 'Input Error' dialog.

Expected results:
No error occurs.

Additional info:
Comment 2 Cole Robinson 2010-05-20 16:06:14 UTC 
We can try to work around this in virt-manager, but this is mostly a libvirt issue with not sanitizing pool target paths. I've posted an upstream libvirt patch to fix this:

https://www.redhat.com/archives/libvir-list/2010-May/msg00748.html

Re-assigning to libvirt.
Comment 3 RHEL Program Management 2010-05-20 17:46:31 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.
Comment 4 Cole Robinson 2010-05-28 19:34:13 UTC 
Created attachment 417727 [details]
Sanitize pool target paths (mail message, misplaced the original patch!)
Comment 5 Dave Allan 2010-06-10 21:33:24 UTC 
libvirt-0_8_1-8_el6 has been built in RHEL-6-candidate with the fix.

Dave
Comment 6 LiZhang Li 2010-06-13 05:20:09 UTC 
Verified under libvirt-0.8.1-8.el6 using virt-manager-0.8.4-3.el6.noarch
Comment 7 releng-rhel@redhat.com 2010-11-11 14:49:15 UTC 
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.