Bug 595320

If we decide to implement RHN Register part of firstboot for RHEL 6 using the ModuleSets, this bugzilla will become a Beta 2 blocker.

The following patch seems to fix the problem and makes walking through the pages working:

--- /usr/lib/python2.6/site-packages/firstboot/interface.py.orig	2010-05-14 13:31:19.000000000 +0200
+++ /usr/lib/python2.6/site-packages/firstboot/interface.py	2010-05-24 13:22:59.157335561 +0200
@@ -34,7 +34,7 @@
         self.history = []
         self.moduleList = []
 
-class Interface:
+class Interface(object):
     def __init__(self, autoscreenshot=False, moduleList=[], testing=False):
         """Create a new Interface instance.  Instance attributes:

However, this patch breaks that sidebar arrow.

In Fedora 12, the arrow is there just fine, even with this patch.

Actually, the sidebar arrow brakage seems to be kinda random in RHEL 6, sometimes it works and sometimes it does not.

Please note that if you set priority = 0 in your moduleset module, running firstboot will still fail, with

firstboot 1.110 exception report
Traceback (most recent call last):
  File "/usr/sbin/firstboot", line 199, in <module>
    config.interface.run()
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 421, in run
    self.displayModule()
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 337, in displayModule
    currentModule.focus()
AttributeError: moduleClass instance has no attribute 'focus'

Another bug in the firstboot code: if the number of modules in your moduleset it greater than the number of the top level modules, stepping to the moduleset shows exception window with

firstboot 1.110.3 exception report
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 105, in _nextClicked
    self.advance()
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 158, in advance
    self.moveToPage(pageNum=self._control.currentPage+1)
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 412, in moveToPage
    self._setPointer(self._controlStack[0].currentPage)
  File "/usr/lib/python2.6/site-packages/firstboot/interface.py", line 116, in _setPointer
    (alignment, label) = self.sidebar.get_children()[i].get_children()
IndexError: list index out of range

The following patch is needed to fix the problem:

--- /usr/lib/python2.6/site-packages/firstboot/interface.py.orig	2010-05-14 13:31:19.000000000 +0200
+++ /usr/lib/python2.6/site-packages/firstboot/interface.py	2010-05-25 13:12:04.663294374 +0200
@@ -111,7 +111,7 @@
         # The sidebar pointer only works in terms of the top-level module list
         # as we don't display anything on the side for a ModuleSet and making
         # the pointer move around then would be confusing.
-        for i in range(len(self.moduleList)):
+        for i in range(len(self.sidebar.get_children())):
             (alignment, label) = self.sidebar.get_children()[i].get_children()
             pix = alignment.get_children()[0]
 

In short, the self.moduleList now (correctly, with the patch from comment 2) points to the list of modules in the moduleset, not to the list of top level modules.

That's why we will just loop over the sidebar children because that's what we essentially care about anyway.

Fixed in version firstboot-1.110.4-1

Red Hat Enterprise Linux Beta 2 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.

*** Bug 635738 has been marked as a duplicate of this bug. ***