Bug 595524
Summary: | Satellite 5.3: ISE when accessing http://server.hostname/ks/dist (should display more graceful permission error page instead of java.lang.ArrayIndexOutOfBoundsException) | ||
---|---|---|---|
Product: | Red Hat Satellite 5 | Reporter: | Xixi <xdmoon> |
Component: | Server | Assignee: | Justin Sherrill <jsherril> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Martin Minar <mminar> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 530 | CC: | cperry, mkoci, mminar, msuchy, xdmoon |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-10-28 15:01:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 487678 |
Description
Xixi
2010-05-24 21:23:59 UTC
Proposed fix is to add checks for url validity in spacewalk-java-0.5.44/code/src/com/redhat/rhn/frontend/action/common/DownloadFile.java below. For example /ks/dist would not have split[2], resulting in ArrayIndexOutOfBoundsException. ... public static Map<String, String> parseDistUrl(String url) { Map<String, String> ret = new HashMap<String, String>(); if (url.charAt(0) == '/') { url = url.substring(1); } String[] split = url.split("/"); int labelPos = 2; if (split[2].equals("org")) { ret.put("orgId", split[3]); labelPos = 4; } .. Fixed in master: ff77e9b12ac95fb2bd0a31cc3ea07f1c03b3279b Throws a file not found error now. verified in stage The 5.4.0 RHN Satellite and RHN Proxy release has occurred. This issue has been resolved with this release. RHEA-2010:0801 - RHN Satellite Server 5.4.0 Upgrade https://rhn.redhat.com/rhn/errata/details/Details.do?eid=10332 RHEA-2010:0803 - RHN Tools enhancement update https://rhn.redhat.com/rhn/errata/details/Details.do?eid=10333 RHEA-2010:0802 - RHN Proxy Server 5.4.0 bug fix update https://rhn.redhat.com/rhn/errata/details/Details.do?eid=10334 RHEA-2010:0800 - RHN Satellite Server 5.4.0 https://rhn.redhat.com/rhn/errata/details/Details.do?eid=10335 Docs are available: http://docs.redhat.com/docs/en-US/Red_Hat_Network_Satellite/index.html Regards, Clifford |