Bug 595676

Summary: Review Request: apache-commons-el - rename of jakarta-commons-el
Product: [Fedora] Fedora Reporter: Stanislav Ochotnicky <sochotni>
Component: Package ReviewAssignee: Alexander Kurtakov <akurtako>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, fedora-package-review, notting
Target Milestone: ---Flags: akurtako: fedora-review+
dennis: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-05-26 08:55:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 588764    

Description Stanislav Ochotnicky 2010-05-25 11:21:43 UTC
Spec URL: http://sochotni.fedorapeople.org/apache-commons-el.spec
SRPM URL: http://sochotni.fedorapeople.org/apache-commons-el-1.0-19.fc12.src.rpm

Description: 
An implementation of standard interfaces and abstract classes for
javax.servlet.jsp.el which is part of the JSP 2.0 specification.

This is a re-review of existing package!

Comment 1 Alexander Kurtakov 2010-05-25 14:36:51 UTC
I'll do this one.

Comment 2 Alexander Kurtakov 2010-05-25 15:04:23 UTC
Review:

OK: rpmlint must be run on every package. Output:

apache-commons-el.noarch: W: spelling-error %description -l en_US javax -> java, java x, Java
apache-commons-el.noarch: W: spelling-error %description -l en_US servlet -> servile, serviette, servility
apache-commons-el.noarch: W: spelling-error %description -l en_US jsp -> esp, asp, tsp
apache-commons-el.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-el
Not a problem. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8. 
OK: I'm aware this is a rename and obsoletes/provides are good.  

This package is APPROVED.

Comment 3 Stanislav Ochotnicky 2010-05-25 15:06:45 UTC
Thanks. Requesting CVS.

New Package CVS Request
=======================
Package Name: apache-commons-el
Short Description: The Apache Commons Extension Language
Owners: sochotni fnasser
Branches: 
InitialCC:

Comment 4 Dennis Gilmore 2010-05-25 20:54:08 UTC
CVS Done

Comment 5 Stanislav Ochotnicky 2010-05-26 08:55:45 UTC
Package built in koji: https://koji.fedoraproject.org/koji/buildinfo?buildID=175135

Thank you, closing.