Bug 596367
Summary: | when allocating a new leg (due to single device failure), the currently healthy log is also replaced | |||
---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Corey Marthaler <cmarthal> | |
Component: | lvm2 | Assignee: | Jonathan Earl Brassow <jbrassow> | |
Status: | CLOSED WONTFIX | QA Contact: | Corey Marthaler <cmarthal> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | 6.0 | CC: | agk, coughlan, ddumas, dwysocha, heinzm, jbrassow, joe.thornber, mbroz, msnitzer, prockai | |
Target Milestone: | rc | Keywords: | Regression, TestBlocker | |
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
When an LVM mirror suffers a device failure, a two-stage recovery takes place.
The first stage involves removing the failed devices. This can result in the
mirror being reduced to a linear device. The second stage — if configured to do so by the administrator — is to attempt to replace any of the failed devices. Note, however, that there is no guarantee that the second stage will choose devices previously in-use by the mirror that had not been part of the failure if others are available.
|
Story Points: | --- | |
Clone Of: | ||||
: | 682648 (view as bug list) | Environment: | ||
Last Closed: | 2010-11-22 23:14:52 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 682648 |
Description
Corey Marthaler
2010-05-26 16:49:31 UTC
Well what's going on here? mimage0 fails. The code could: (1) Reduce the mirror to a linear device, then convert it back to a mirror. This involves allocating a new mimage1 and a new log. If you want it to keep the old log then it's the job of that code to remember where the log was and supply that to the allocation code, but I see no need for this. Or just detach the log before reducing the mirror, and reattach it when creating the new mirror. (2) Move the mimage1 to the primary, mark the log as fully out-of-sync, and allocate a new secondary. This keeps the log in the same place because it never removes it. Does the code do (1) or (2)? To see this effect, (1) I presume. To change the behaviour, it would need to do (2). There's nothing in the current code that says "logs will only be allocated from particular PVs". There's nothing to fix in the allocation code here. It would be nice to improve the behaviour, but how much of the "repair" code would have to be changed to do that? And is it worth it? From a QE perspective, issues like this where there are changes in behavior from one release to another, but never any requirements alerting us of changes to come make it difficult to plan for test development/test changes. If behavior is going to be changed, it needs to be written down ahead of time so that we can plan for it, instead of just seeing what behavior has changed after code is given to QE and they deal with test failures. Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: When an LVM mirror suffers a device failure, a two-stage recovery takes place. The first stage involves removing the failed devices. This can result in the mirror being reduced to a linear device. The second stage is to attempt to replace any of the failed devices, if configured to do so by the administrator. There is no gaurentee that the second stage will choose devices previously in-use by the mirror that had not been part of the failure if others are available. Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1,3 @@ -When an LVM mirror suffers a device failure, a two-stage recovery takes place. The first stage involves removing the failed devices. This can result in the mirror being reduced to a linear device. The second stage is to attempt to replace any of the failed devices, if configured to do so by the administrator. There is no gaurentee that the second stage will choose devices previously in-use by the mirror that had not been part of the failure if others are available.+When an LVM mirror suffers a device failure, a two-stage recovery takes place. +The first stage involves removing the failed devices. This can result in the +mirror being reduced to a linear device. The second stage — if configured to do so by the administrator — is to attempt to replace any of the failed devices. Note, however, that there is no guarantee that the second stage will choose devices previously in-use by the mirror that had not been part of the failure if others are available. Development Management has reviewed and declined this request. You may appeal this decision by reopening this request. |