Bug 596410

Two parts to this bz.

1 - a UI to ack a task failure.  record who did the ack as well.

2 - Update matrix report to only show results that are not acked.  or show them but with a different color?

After talking with those concerned I've come up with the following

1 - Have a menu on the matrix report page that will allow the acking of tasks (at the recipeset level initially)

2 - Have this ack data persistently stored so it's remembered for every time the job is viewed 

3 - ignore results of acked tasks

4 - a reason textbox.

What I've implemented so far I've thrown up on beaker-stage.
It's complete minus the comments.

Tested it on firefox 3.5

Created attachment 422712 [details]
screen shot showing different place for ack/nak/needs review.


Hi Ray,

Can we move the Ack/Nak to the recipeSet view? In its current form you don't have the information handy to determine if the recipeSet is valid or not.

The attached pic shows what I'm thinking..

Also some transcript from Jeff and I on irc..

<bpeck> In fact.. how about
 ( ) Ack    ( ) Nack  (*) Not looked at
 or Not Reviewed
<jburke> I guess that would make sense but then I would explicily have to either nack or ack
 less work the better
<bpeck> I thought one of the things you wanted was so that other reviewers would know you looked at this failure already
 I acknowledge this failure.
 no need to investiagte again
<jburke> treu
 true
<bpeck> I suppose only failed recipesets need this
<jburke> fail/warn
<bpeck> or we default pass to "Ack:
<jburke> I think you can get away with only two Ack and Needs Review.
 Pass will default to Ack, Fail/Warn default to Need Review
 Once it is reviewed it is then moved to Ack
<bpeck> but then it will show up?
 in the matrix
<jburke> not sure I guess it depends on implementation
* jburke getting confused
<jburke> heh
<bpeck> were trying to accomplish two things.    Has someone looked at this result.   and is it a valid result
<jburke>  Has someone looked at this result. = Needs Review.  Is it a vaid result = Ack
<bpeck> ok
<jburke> but let me verify I am not over simplifing this
<bpeck> so we still need nak
<jburke> nak will be for hiding it from the matirx view
<bpeck> maybe the radio button is throwing you
 yes
<jburke> ok I got it
<bpeck> only one of those states can be valid at once
<jburke> right
<bpeck> so the current view looks correct then?
 or do we need more review?
<jburke> No I think it is good
<bpeck> ok
 should the matrix report include a list at the bottom of excluded recipes?  with comments?
 it would be off the screen normally
<jburke> a key/legend?
<bpeck> no
<jburke> ok I gotcha
 hmm
<bpeck> like an audit trail
 this report shows all green.  but look below for exceptions
<jburke> maybe a show all
 have the option to look at the matrix "as-is" now ack/nack override
 now = no
 No how you have a show all results button
 mNo = know



So to summarize:

RecipeSet.Status != Pass    Default to "Needs Review"
RecipeSet.Status == Pass    Default to "AcK"


And on the Matrix page itself we would like an option for overriding the Naks.  

[ ] Show All


The above provides two features actually. 

1) Allows invalid results to be omitted
2) provides feedback to reviewers about which results need review.

Based on what I've read above, I've created something which should fit the bill.
It's on http://beaker-stage.app.eng.bos.redhat.com at the moment.

Once it's not "Needs Review" it can never need review again.
It's also only accesable by owner or admin.

Please let me know if anything needs changing (other than the omission of comments, they're still coming).

It's up on beaker-devel.bne but I won't be submitting it until i can fix my testing....

This has been commited

http://git.fedorahosted.org/git/?p=beaker.git;a=shortlog;h=refs/heads/bz596410

merged into master. Should be in 0.5.48 release.

Wow! That's a great feature! Thanks, guys!