Bug 596433
| Summary: | Behavior change for .private dependency causes rpm dependency detection breakage | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> | ||||
| Component: | redhat-rpm-config | Assignee: | Panu Matilainen <pmatilai> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | rawhide | CC: | jonathan, linuxdonald, mclasen, otte, pmatilai | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-05-27 12:45:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 582106 | ||||||
| Attachments: |
|
||||||
|
Description
Mamoru TASAKA
2010-05-26 18:23:23 UTC
(In reply to comment #0) > However with GConf2-devel-2.31.3-1.fc14.i686 : > http://koji.fedoraproject.org/koji/rpminfo?rpmID=1990870 > Requires(dbus-1) does not appear in Requires. On the other hand, > with GConf2-devel-2.28.1-1.fc13.i686: > http://koji.fedoraproject.org/koji/rpminfo?rpmID=1896589 > Requires(dbus-1) is actually there. > should be read as "pkgconfig(dbus-1)". What happened here is that our patch to add --print-requires finally moved upstream. But on the way, it got split up into --print-requires and --print-requires-private. To keep the same behavior, find-requires.pkg-config needs to be updated to pass both options to pkg-config. Created attachment 417064 [details]
patch
I'd be happy to build this if you have no objections
(In reply to comment #3) > Created an attachment (id=417064) [details] > patch > > I'd be happy to build this if you have no objections Seems good to me (this patch should only be applied to rawhide redhat-rpm-config, because pkg-config 0.23 does not seem to accept --print-requires-private). Good to hear it finally got upstreamed.
Just FYI, find-requires.pkg-config isn't what normally gets used. It only runs when the internal dependency generator is disabled (which is strongly frowned upon in Fedora as various important bits are missed by the older, external dep generator). What really needs patching is this in rpm's main macros file (will fix):
%__pkgconfig_requires %{_rpmconfigdir}/pkgconfigdeps.sh --requires
Oops, of course its pkgconfigdeps.sh which needs patching, the arguments from the macro dont directly reflect what pkgconfigdeps.sh calls pkg-config with. Anyway, fixed in both rpm-4.8.0-16.fc14 and redhat-rpm-config-9.1.0-5.fc14 now. I rebuilt GConf2 and it seems good, thank you. |