Bug 596660
| Summary: | Review Request: crimson-text-fonts - A latin font for the production of technical books and papers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Daiki Ueno <dueno> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dueno, fedora-package-review, i18n-bugs, notting |
| Target Milestone: | --- | Flags: | dueno:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-01 06:36:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Parag Nemade
2010-05-27 09:15:49 UTC
Mostly ok. According to the web page: http://aldusleaf.org the font is under development and font files are frequently replaced, so I think this is the case of "Pre-Release packages": https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages I would suggest "Version: 0" and "Release: 0.1.20100523%{?dist}", or use the version 0.01 in Google Font Directory. Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/crimson-text-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/crimson-text-fonts-0-0.1.20100523.fc13.src.rpm Sorry, one more thing. There is a critical typo in %install:
install -m 0644 -p %{SOURCE1} \
%{buildroot}%{_fontconfig_templatedir}/%{fontconf}
should be:
install -m 0644 -p %{SOURCE3} \
%{buildroot}%{_fontconfig_templatedir}/%{fontconf}
I wonder why I didn't notice this in the previous test.
All the rest looks ok.
Thank you for the review Daiki. New Package CVS Request ======================= Package Name: crimson-text-fonts Short Description: A latin font for the production of technical books and papers Owners: pnemade Branches: F-13 InitialCC: fonts-sig i18n-team CVS done (by process-cvs-requests.py). crimson-text-fonts-0-0.1.20100523.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/crimson-text-fonts-0-0.1.20100523.fc13 crimson-text-fonts-0-0.1.20100523.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update crimson-text-fonts'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/crimson-text-fonts-0-0.1.20100523.fc13 |