Bug 597864
| Summary: | createnet: Wizard complains about wrong DHCP network when DHCP is turned off | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Niels de Vos <ndevos> | ||||
| Component: | virt-manager | Assignee: | Cole Robinson <crobinso> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | berrange, crobinso, hbrock, jforbes, virt-maint | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | virt-manager-0.8.5-1.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-09-04 04:59:36 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Thanks for the patch! I extended it slightly and applied upstream: http://hg.fedorahosted.org/hg/virt-manager/rev/4cd962f6722b You're welcome :) virt-manager-0.8.5-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/virt-manager-0.8.5-1.fc13 virt-manager-0.8.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update virt-manager'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/virt-manager-0.8.5-1.fc13 virt-manager-0.8.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update virt-manager'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/virt-manager-0.8.5-1.fc13 virt-manager-0.8.5-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 418089 [details] adds a check if DHCP is enabled before raising the error(s) Description of problem: On creating a network, the wizard complains that the DHCP-range is not in the selected IP-network. Version-Release number of selected component (if applicable): virt-manager-0.8.3-3.fc13.noarch How reproducible: 100% Steps to Reproduce: 1. click the '+' button on the 'virtual networks' tab of the 'Host details' 2. read the description and click 'forward' 3. enter a name and click 'forward' 4. keep the proposed IP-network and click 'forward' 5. unselect 'Enable DHCP' and click 'back' 6. change the IP-network to something (valid) else and click 'forward' 7. note the previous (inactive) DHCP-range and click 'forward' 8. error: "Invalid DHCP Address" Actual results: A popup with error: "Invalid DHCP Address" Expected results: DHCP is disabled, so there is no need to display an error. Additional info: I'd like to propose the attached patch for inclusion. The patch adds a check if DHCP is enabled before raising the error(s).