Bug 597866

Summary: Improve readability of the variables in ifplugd.action (patch)
Product: [Fedora] Fedora Reporter: Niels de Vos <ndevos>
Component: ifplugdAssignee: José Matos <jamatos>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 13CC: jamatos, rpandit
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ifplugd-0.28-15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-05 20:17:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
improve readability of ifplugd.action none

Description Niels de Vos 2010-05-30 20:24:42 UTC
Created attachment 418091 [details]
improve readability of ifplugd.action

Description of problem:

$1 and $2 are easily mistaken and are not documented in the header of the file. Assigning clear variable names improved readability and makes it easier to change the script.


Version-Release number of selected component (if applicable):

ifplugd-0.28-14.fc12.x86_64 (fc12 comes with Fedora 13)

Comment 1 Niels de Vos 2010-11-05 20:17:33 UTC
Thanks for including this patch!

$ rpm -q --changelog ifplugd | head -n2
* Mon May 31 2010 José Matos <jamatos@fc.up.pt> - 0.28-15
- Add action readability patch (thanks to Niels de Vos) (bz#597866)