Bug 597967
| Summary: | Review Request: emacs-ibus - IBus client for GNU Emacs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | emacs-ibus-0.1.0-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-14 17:16:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daiki Ueno
2010-05-31 06:20:43 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2221510 + rpmlint output for SRPM and for RPM. emacs-ibus.src: W: spelling-error %description -l en_US el -> e, l, eel emacs-ibus.noarch: E: explicit-lib-dependency python-xlib emacs-ibus.noarch: W: spelling-error %description -l en_US el -> e, l, eel emacs-ibus-el.noarch: W: spelling-error Summary(en_US) Elisp -> Lisp, Elise, Elisa emacs-ibus-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise emacs-ibus-el.noarch: W: no-documentation ==> All are ok to be ignored. + source files match upstream url (sha1sum) c066f17640d51b91d39bffbc991f946a73469499 ibus-el-0.1.0.tar.gz c066f17640d51b91d39bffbc991f946a73469499 ibus-el-0.1.0.tar.gz.srpm ( I see that when tried to download using wget, I get 2010-06-01 11:33:52 ERROR 403: Forbidden. Not sure why its happening but I can download it using browser) + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + no headers or static libraries. + emacs-ibus-el subpackage exists. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application + Other than requires on emacs missing, this package follows emacs addon packaging guidelines. Suggestions: 1) As per https://fedoraproject.org/wiki/Packaging:Emacs#Package_Requires_and_BuildRequires, emacs-ibus must have Requires: emacs(bin) >= %{_emacs_version} 2) Good if timestamps are preserved as per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps APPROVED. Also if you are planning only to build for F-13 and above you can ignore writing buildroot and %clean sections. See http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and http://fedoraproject.org/wiki/PackagingGuidelines#.25clean Thanks for the review. New Package CVS Request ======================= Package Name: emacs-ibus Short Description: IBus client for GNU Emacs Owners: ueno Branches: F-13 F-12 InitialCC: i18n-team CVS done (by process-cvs-requests.py). emacs-ibus-0.1.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc13 emacs-ibus-0.1.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc12 emacs-ibus-0.1.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update emacs-ibus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc12 emacs-ibus-0.1.0-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update emacs-ibus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc13 emacs-ibus-0.1.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. emacs-ibus-0.1.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |