Bug 598087
Summary: | Traceback in rescue mode when adding zFCP LUN defined in CMS config file. | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Jan Stodola <jstodola> |
Component: | anaconda | Assignee: | David Cantrell <dcantrell> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Release Test Team <release-test-team-automation> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 6.0 | CC: | maier, rwilliam |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | s390x | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | anaconda-13.21.51-1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-11-10 19:46:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 582286 |
Description
Jan Stodola
2010-05-31 12:12:08 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Every caller (direct or indirect) of ZFCP.addFCP in storage/zfcp.py must catch ValueError exceptions and either display an error dialog box (if there is a UI) or log the error (otherwise). Apparently this rule even applies to zfcp.py itself. :-) ZFCP.readConfig calls addFCP without catching ValueError. Maybe we should pass self.anaconda.intf to zfcp.startup as we do with dasd, iscsi, and fcoe. Then ZFCP.readConfig can use it to decide between displaying an error dialog box or logging a caught ValueError. I suppose we have never seen this case before, since rescue now seems to perform the add drive dialog _before_ initializing storage, whereas anaconda does it the other way round and the user would have gotten an error dialog on trying to add the same lun with the add drive dialog (iw/advanced_storage.py, textw/add_drive_text.py). (Besides addFCP, the same goes for most methods of ZFCPDevice although these are not meant to be public interfaces outside of zfcp.py.) Excellent test case, Jan, BTW! > Maybe we should pass self.anaconda.intf to zfcp.startup as we do with dasd, > iscsi, and fcoe. Then ZFCP.readConfig can use it to decide between displaying > an error dialog box or logging a caught ValueError. Bug 597101 (which seems a dup of this one here) reminded me of the fact that there might be multiple callers of ZFCP.startup that would have to be modified to pass in anaconda.intf: iw/filter_gui.py:FilterWindow.getScreen Not sure about this one, since none of iscsi, fcoe, dasd pass intf here: storage/__init__.py:Storage.__init__ I guess it's a matter of we want users to get dialogs or have them dig in /tmp/anaconda.log if something went wrong which they might not even notice if we just log. The following callers don't seem to have intf anyway so they don't need any change: kickstart.py:parseKickstart *** Bug 597101 has been marked as a duplicate of this bug. *** There is no traceback when adding the same zFCP LUN that was defined in CMS config file, user see error message: ┌─────────────────────┤ Error ├─────────────────────┐ │ │ │ LUN 0x4020400100000000 at WWPN 0x500507630503c73d │ │ on zFCP device 0.0.a000 already configured. │ │ │ │ ┌────┐ │ │ │ OK │ │ │ └────┘ │ │ │ │ │ └───────────────────────────────────────────────────┘ Tested on build RHEL6.0-20100701.0 with anaconda-13.21.56-1.el6. Moving to VERIFIED. Red Hat Enterprise Linux 6.0 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. |