Bug 598120

Summary: netpanzer version is not 0.8.3, missing sounds
Product: [Fedora] Fedora Reporter: Aaron Perez Sanchez <aaronps>
Component: netpanzerAssignee: Gwyn Ciesla <gwync>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: low    
Version: 13CC: gwync, lxtnow
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: netpanzer-0.8.3.svn612010-2.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-06-08 19:29:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Modified spec
none
SConstruct fixes patch none

Description Aaron Perez Sanchez 2010-05-31 13:40:58 UTC 
Created attachment 418302 [details]
Modified spec

Description of problem:
1- The source code included in the package netpanzer-0.8.3 is not in fact 0.8.3, it was taken from "trunk". This make the game incompatible with the real 0.8.3. The trunk is reserved for development and uses a different communication protocol. The correct path is:

http://svn.berlios.de/svnroot/repos/netpanzer/tags/netpanzer/0.8.3

It also didn't have a version string attached to the window and some of the protocol messages (it is taken from a file in the correct path 'RELEASE_VERSION', which you could modify if you want to attach some extra tags related to fedora, keep 0.8.3 please).

2- The spec file has incorrect dependencies, some of them are not used.

3- The sounds are not included in the installation, they are missing in the %install

4- The SConstruct file needed a quick fix, I believe (doesn't have prove) it _might_ be possible that the source code is compiled with some system headers but linked with a internal library (instead of using the internal headers and internal library) with that SConstruct, it _might_ generate some unwanted crashes.

Version-Release number of selected component (if applicable):
0.8.3-1

How to fix:
I have modified the spec file and created a patch for SConstruct, you should export the correct source from svn, like:

# svn export http://svn.berlios.de/svnroot/repos/netpanzer/tags/netpanzer/0.8.3 netpanzer-0.8.3
Comment 1 Aaron Perez Sanchez 2010-05-31 13:42:15 UTC 
Created attachment 418303 [details]
SConstruct fixes patch
Comment 2 Aaron Perez Sanchez 2010-05-31 13:44:36 UTC 
I forgot to say I'm what you call upstream, feel free to contact in netpanzer.org forum (called 'krom' there) or by mail.
Comment 3 Gwyn Ciesla 2010-06-01 20:03:49 UTC 
Ok, thanks for the information.  I checked out the correct version, applied the scons patch, and put sound back.  Updates are coming.
Comment 4 Fedora Update System 2010-06-01 20:07:59 UTC 
netpanzer-0.8.3.svn612010-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/netpanzer-0.8.3.svn612010-2.fc13
Comment 5 Fedora Update System 2010-06-01 20:08:14 UTC 
netpanzer-0.8.3.svn612010-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/netpanzer-0.8.3.svn612010-2.fc12
Comment 6 Fedora Update System 2010-06-02 18:00:29 UTC 
netpanzer-0.8.3.svn612010-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update netpanzer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/netpanzer-0.8.3.svn612010-2.fc12
Comment 7 Fedora Update System 2010-06-02 18:06:22 UTC 
netpanzer-0.8.3.svn612010-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update netpanzer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/netpanzer-0.8.3.svn612010-2.fc13
Comment 8 Fedora Update System 2010-06-08 19:29:05 UTC 
netpanzer-0.8.3.svn612010-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 9 Fedora Update System 2010-06-08 19:30:05 UTC 
netpanzer-0.8.3.svn612010-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.