Bug 598402

Summary: Review Request: maven-ejb-plugin - Maven EJB Plugin
Product: [Fedora] Fedora Reporter: huwang <huwang>
Component: Package ReviewAssignee: Alexander Kurtakov <akurtako>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, fedora-package-review, notting
Target Milestone: ---Flags: akurtako: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-06-04 10:52:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description huwang 2010-06-01 10:18:23 UTC
Spec URL: http://huwang.fedorapeople.org/packages/maven-ejb-plugin/maven-ejb-plugin.spec
SRPM URL: http://huwang.fedorapeople.org/packages/maven-ejb-plugin/maven-ejb-plugin-2.2.1-1.src.rpm
Description: Generates a J2EE Enterprise JavaBean (EJB) file as well as the associated client JAR.

Comment 1 huwang 2010-06-01 10:20:49 UTC
Scratch built with dist-f14-maven221 target in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2221846

Comment 2 Alexander Kurtakov 2010-06-01 19:33:39 UTC
I'm taking this one.

Comment 3 Alexander Kurtakov 2010-06-01 19:44:02 UTC
Review:

FIXIT: rpmlint must be run on every package. Output:
maven-ejb-plugin.noarch: E: description-line-too-long C Generates a J2EE Enterprise JavaBean (EJB) file as well as the associated client JAR.

Make it two lines.

maven-ejb-plugin.noarch: W: self-obsoletion maven2-plugin-ejb <= 0:2.0.8 obsoletes maven2-plugin-ejb = 2.2.1-1.fc13
Provide with epoch.

maven-ejb-plugin.noarch: W: no-documentation
maven-ejb-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-ejb-plugin

False positives. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 

FIXIT: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
Tarball generation instructions are wrong. They point to the maven-docck-plugin svn.

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.

Comment 4 huwang 2010-06-02 02:36:45 UTC
(In reply to comment #3)
> Review:
> 
> FIXIT: rpmlint must be run on every package. Output:
> maven-ejb-plugin.noarch: E: description-line-too-long C Generates a J2EE
> Enterprise JavaBean (EJB) file as well as the associated client JAR.
Fixed
> 
> Make it two lines.
> 
> maven-ejb-plugin.noarch: W: self-obsoletion maven2-plugin-ejb <= 0:2.0.8
> obsoletes maven2-plugin-ejb = 2.2.1-1.fc13
> Provide with epoch.
Fixed
> 
> maven-ejb-plugin.noarch: W: no-documentation
> maven-ejb-plugin.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-ejb-plugin
> 
> False positives. 
> 
> OK: The package must be named according to the Package Naming Guidelines .
> OK: The spec file name must match the base package %{name}, in the format
> %{name}.spec unless your package has an exemption. 
> OK: The package must meet the Packaging Guidelines .
> OK: The package must be licensed with a Fedora approved license and meet the
> Licensing Guidelines .
> OK: The License field in the package spec file must match the actual license.
> OK: If (and only if) the source package includes the text of the license(s) in
> its own file, then that file, containing the text of the license(s) for the
> package must be included in %doc.
> OK: The spec file must be written in American English. 
> OK: The spec file for the package MUST be legible. 
> 
> FIXIT: The sources used to build the package must match the upstream source, as
> provided in the spec URL. 
> Tarball generation instructions are wrong. They point to the maven-docck-plugin
> svn.
Fixed
> 
> OK: The package MUST successfully compile and build into binary rpms on at
> least one primary architecture. 
> OK: All build dependencies must be listed in BuildRequires, except for any that
> are listed in the exceptions section of the Packaging Guidelines ; inclusion of
> those as BuildRequires is optional. Apply common sense.
> OK: Packages must NOT bundle copies of system libraries.
> OK: A package must own all directories that it creates. If it does not create a
> directory that it uses, then it should require a package which does create that
> directory. 
> OK: A Fedora package must not list a file more than once in the spec file's
> %files listings. 
> OK: Permissions on files must be set properly. Executables should be set
> with executable permissions, for example. Every %files section must include a
> %defattr(...) line. 
> OK: Each package must consistently use macros. 
> OK: The package must contain code, or permissable content. 
> OK: Large documentation files must go in a -doc subpackage. 
> OK: If a package includes something as %doc, it must not affect the runtime of
> the application. 
> OK: Packages must not own files or directories already owned by other packages. 
> OK: All filenames in rpm packages must be valid UTF-8.    


Spec URL: http://huwang.fedorapeople.org/packages/maven-ejb-plugin/maven-ejb-plugin.spec

SRPM URL: http://huwang.fedorapeople.org/packages/maven-ejb-plugin/maven-ejb-plugin-2.2.1-2.src.rpm

scratch built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2224026

please review again, thanks.

Comment 5 Alexander Kurtakov 2010-06-02 06:39:14 UTC
Looks good, thanks.

This package is APPROVED.

Comment 6 huwang 2010-06-02 08:09:53 UTC
New Package CVS Request
=======================
Package Name: maven-ejb-plugin
Short Description: Maven EJB Plugin
Owners: huwang
Branches: 
InitialCC:

Comment 7 Kevin Fenzi 2010-06-03 20:33:39 UTC
CVS done (by process-cvs-requests.py).

Comment 8 huwang 2010-06-04 10:52:15 UTC
Built in koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=176595