Bug 598535

Summary: the gnome-keyring-daemon needs proper locking around memory allocations functions
Product: [Fedora] Fedora Reporter: Fabrice Bellet <fabrice>
Component: gnome-keyringAssignee: Tomáš Bžatek <tbzatek>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 13CC: fabrice, tbzatek, tsmetana, walters
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-06-29 16:51:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to add locking for memory ops in the gkd none

Description Fabrice Bellet 2010-06-01 15:16:40 UTC 
the gnome-keyring-daemon crashes frequently in egg-secure-memory.c, specifically when it is used as a ssh agent, with a lot of concurrent ssh sessions. The memory allocation functions in egg/egg-secure-memory.c are protected by DO_LOCK() / DO_UNLOCK() macros, with appear to be no-op in the case of the gnome-keyring-daemon (daemon/gkd-main.c), which is probably not a good idea, because it works in a threaded environment when creating client threads in gkd_ssh_agent_accept().

So I think a real locking should be added in daemon/gkd-main.c

patch is attached.
Comment 1 Fabrice Bellet 2010-06-01 15:18:00 UTC 
Created attachment 418678 [details]
patch to add locking for memory ops in the gkd
Comment 2 Fabrice Bellet 2010-06-29 16:51:07 UTC 
This is fixed in 2.30.3. thanks!