Bug 598980
| Summary: | Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shreyank Gupta <sgupta> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, sgupta, shreyankg |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-lockfile-1.4.3-4.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-10 19:22:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 601633, 601641 | ||
|
Description
Shreyank Gupta
2010-06-02 13:30:14 UTC
Koji Scratch Build ------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2225105 (Removing NEEDSPONSOR) For -1:
* License (tag)
- Please include the following file as SOURCE1 (with full URL),
install the file under %geminstdir, mark the file as %doc
and include in main package.
http://codeforpeople.com/lib/license.txt
- When the license is "the same as Ruby", we use "GPLv2 or Ruby"
(not v2+) for license tag in the spec file.
* bin/ directory
--------------------------------------------------------------
$ rlock
/usr/bin/rlock:19:in `load': no such file to load -- /usr/lib/ruby/gems/1.8/gems/lockfile-1.4.3/bin/rlock (LoadError)
from /usr/bin/rlock:19
--------------------------------------------------------------
- %{geminstdir}/bin directory must not be removed and should
be in main package.
Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-2.fc13.src.rpm One issue - When using "cp" or "install" command for files, please add "-p" option to keep timestamps on installed files. https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps Please fix the above when importing this package into Fedora. ------------------------------------------------------------------ This package (rubygem-lockfile) is APPROVED by mtasaka ------------------------------------------------------------------ Thanks for the review, I'll update the specfile and SRPMs tomorrow. Meanwhile .. New Package CVS Request ======================= Package Name: rubygem-lockfile Short Description: Ruby library for creating NFS safe lockfiles Owners: shreyankg Branches: F-13 CVS done (by process-cvs-requests.py). Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-3.fc13.src.rpm Well, I have not checked your new spec in detail, however - "install" command usually sets the permission of the file to be installed to "0755" instead of "0644". Please check if "license.txt" has 0644 permission. Sorry! Thanks for pointing that out: Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/lockfile/rubygem-lockfile-1.4.3-4.fc13.src.rpm Seems okay. Please import. rubygem-lockfile-1.4.3-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-lockfile-1.4.3-4.fc13 rubygem-lockfile-1.4.3-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-lockfile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-lockfile-1.4.3-4.fc13 rubygem-lockfile-1.4.3-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |