Bug 599291
Summary: | Review Request: maven-ear-plugin - Maven EAR Plugin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | huwang <huwang> |
Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
Target Milestone: | --- | Flags: | akurtako:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-06-08 08:21:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
huwang
2010-06-03 04:01:54 UTC
I'll take this one. Review: OK: rpmlint must be run on every package. Output: maven-ear-plugin.noarch: W: no-documentation maven-ear-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-ear-plugin False positives. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. OK: Provides/Obsoletes are good. FIXIT: The package should at least Requires: maven2 maybe there are even others missing. (In reply to comment #2) > Review: > > OK: rpmlint must be run on every package. Output: > maven-ear-plugin.noarch: W: no-documentation > maven-ear-plugin.noarch: W: non-conffile-in-etc > /etc/maven/fragments/maven-ear-plugin > > False positives. > > OK: The package must be named according to the Package Naming Guidelines . > OK: The spec file name must match the base package %{name}, in the format > %{name}.spec unless your package has an exemption. > OK: The package must meet the Packaging Guidelines . > OK: The package must be licensed with a Fedora approved license and meet the > Licensing Guidelines . > OK: The License field in the package spec file must match the actual license. > OK: If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package must be included in %doc. > OK: The spec file must be written in American English. > OK: The spec file for the package MUST be legible. > OK: The sources used to build the package must match the upstream source, as > provided in the spec URL. > OK: The package MUST successfully compile and build into binary rpms on at > least one primary architecture. > OK: All build dependencies must be listed in BuildRequires, except for any that > are listed in the exceptions section of the Packaging Guidelines ; inclusion of > those as BuildRequires is optional. Apply common sense. > OK: Packages must NOT bundle copies of system libraries. > OK: A package must own all directories that it creates. If it does not create a > directory that it uses, then it should require a package which does create that > directory. > OK: A Fedora package must not list a file more than once in the spec file's > %files listings. > OK: Permissions on files must be set properly. Executables should be set > with executable permissions, for example. Every %files section must include a > %defattr(...) line. > OK: Each package must consistently use macros. > OK: The package must contain code, or permissable content. > OK: Large documentation files must go in a -doc subpackage. > OK: If a package includes something as %doc, it must not affect the runtime of > the application. > OK: Packages must not own files or directories already owned by other packages. > OK: All filenames in rpm packages must be valid UTF-8. > OK: Provides/Obsoletes are good. > > FIXIT: The package should at least Requires: maven2 maybe there are even others > missing. Fixed. Please review again, thanks. Spec URL: http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin.spec SRPM URL: http://huwang.fedorapeople.org/packages/maven-ear-plugin/maven-ear-plugin-2.4.2-2.src.rpm Scratch build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2234492 Thanks, Looks good. Package is APPROVED. New Package CVS Request ======================= Package Name: maven-ear-plugin Short Description: Maven EAR Plugin Owners: huwang Branches: InitialCC: CVS done (by process-cvs-requests.py). Built in koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=177248 |