Bug 599427

Summary: rpmlint does not ignore comments in the spec
Product: [Fedora] Fedora Reporter: Ankur Sinha (FranciscoD) <sanjay.ankur>
Component: rpmlintAssignee: Ville Skyttä <ville.skytta>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: low    
Version: 13CC: manuel.wolfshant, tmz, ville.skytta
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rpmlint-0.98-1.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-01 18:47:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sample spec for testing none

Description Ankur Sinha (FranciscoD) 2010-06-03 08:29:32 UTC 
Description of problem:
rpmlint gives errors/warnings even based on comments in a spec. The comments should be ignored by rpmlint


Version-Release number of selected component (if applicable):
[Ankur@localhost SPECS]$ rpm -q rpmlint
rpmlint-0.97-1.fc13.noarch

How reproducible:
Add a comment to a spec which has an "rpmlint error"


Steps to Reproduce:
1. add a comment which would otherwise be an error
2. run rpmlint

  
Actual results:
It gives warnings on the comment too

Expected results:
Comments should be ignored

Additional info:
Try this spec:

http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec
(attaching it for future reference)

line 36 is a comment on ./configure.

rpmlint gives:

[Ankur@localhost SPECS]$ rpmlint libgexiv2.spec 
libgexiv2.spec:36: W: configure-without-libdir-spec
Comment 1 Ankur Sinha (FranciscoD) 2010-06-03 08:30:23 UTC 
Created attachment 419276 [details]
sample spec for testing
Comment 2 Ville Skyttä 2010-06-03 21:32:03 UTC 
http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1788
http://rpmlint.zarb.org/cgi-bin/trac.cgi/changeset/1789
Comment 3 Fedora Update System 2010-06-23 19:53:19 UTC 
rpmlint-0.98-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/rpmlint-0.98-1.fc13
Comment 4 Fedora Update System 2010-06-23 19:53:52 UTC 
rpmlint-0.98-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rpmlint-0.98-1.fc12
Comment 5 Fedora Update System 2010-06-24 16:23:40 UTC 
rpmlint-0.98-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rpmlint'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rpmlint-0.98-1.fc13
Comment 6 Fedora Update System 2010-07-01 18:46:54 UTC 
rpmlint-0.98-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2010-07-01 18:54:06 UTC 
rpmlint-0.98-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.