Bug 600227
Summary: | Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Yong Yang <yyang> |
Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | akurtako, fedora-package-review, notting |
Target Milestone: | --- | Flags: | akurtako:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-06-09 06:08:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Yong Yang
2010-06-04 08:02:34 UTC
I'll take this one. hmm, it points to stage plugin srpm. Fixed srpm url and minor issues: Spec URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin-2.3-1.src.rpm Review: FIXIT: rpmlint must be run on every package. Output: maven-repository-plugin.noarch: E: summary-too-long C Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository Fix it. maven-repository-plugin.noarch: W: no-documentation maven-repository-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-repository-plugin False positives. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. OK: Provides/Obsoletes are good. Ooops, I missed the Lisense.txt is shipped in the tarball. Please include it as %doc Changelog: - Update summary due to length issue - Add LICENSE.txt Please review again. Spec URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin-2.3-2.src.rpm Thanks, This package is APPROVED. New Package CVS Request ======================= Package Name: maven-repository-plugin Short Description: Plugin to create bundles of artifacts for manual uploaded to repository Owners: yyang Branches: devel InitialCC: huwang liweinan akurtako dbhole cvs done, except liweinan account doesn't exist. Hi Kevin, cvs is not done yet after 12 hours passed, may be caused by wrong CC, please create cvs again and leave CC blank, thanks. New Package CVS Request ======================= Package Name: maven-repository-plugin Short Description: Plugin to create bundles of artifacts for manual uploaded to repository Owners: yyang Branches: devel InitialCC: |