Bug 600529

Summary: Review Request: R-rjags - Bayesian graphical models using MCMC
Product: [Fedora] Fedora Reporter: chris desjardins <cddesjardins>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, pingou, randyn3lrx
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-19 17:47:51 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On: 600467    
Bug Blocks: 201449    

Description chris desjardins 2010-06-04 18:31:54 EDT
Spec URL: http://dl.dropbox.com/u/1501309/Fedora/R-rjags.spec
SRPM URL: http://dl.dropbox.com/u/1501309/Fedora/R-rjags-2.1.0.4-1.fc13.src.rpm
Description: 
Bayesian graphical models using MCMC. rjags is an R interface to the JAGS MCMC library
Comment 1 Pierre-YvesChibon 2010-06-04 19:01:34 EDT
As a quick look at the spec:
- The URL is not correct
- The BuildRequires to tetex-latex has to be updated
- The Requires for post and postun can be removed
- you might want to change the Requires from R to R-core 
- You have a double dependency on R in your BuildRequires 
- The comment on the %install is incorrect (also in %files)

The rest look correct, I will do a deeper pre-review (as I can not sponsor you) later.
Comment 2 chris desjardins 2010-06-04 19:26:48 EDT
I have made the changes to my *.spec file and have updated new versions of the *.spec and *.src.rpm files. They can be obtained by clicking my original urls in the description box.
Comment 3 chris desjardins 2010-06-04 19:28:12 EDT
I will update the *.spec file with new version and a changelog. Sorry!
Comment 4 chris desjardins 2010-06-04 20:09:47 EDT
Here is the new *.spec file and the new *src.rpm addressing Pierre's issues.

http://dl.dropbox.com/u/1501309/Fedora/R-rjags.spec
http://dl.dropbox.com/u/1501309/Fedora/R-rjags-2.1.0.4-2.fc13.src.rpm
Comment 5 Pierre-YvesChibon 2010-06-05 08:41:57 EDT
* Latest version packaged
Target is already in the folder, no need to re-download it
7b3a345ad25b859c053111e607c8caa312a943ae  rjags_2.1.0-4.tar.gz
7b3a345ad25b859c053111e607c8caa312a943ae  /home/pierrey/rpmbuild/SOURCES/rjags_2.1.0-4.tar.gz
* sha1sum are equals
* All required Requires are present
* All required BuildRequires are present
* The macro %check is present
* There is 1 %dir
  %dir is OK
* There is 2 %doc
  %doc is OK
* The rpm installed in _libdir
* The rpm uses %{_libdir} and is arch
* The rpm seems to have the required element in %install
rpmbuild -ba /home/pierrey/rpmbuild/SPECS/R-rjags.spec > R-rjags.spec-build.log 2>&1 
! Does not build properly

I believe you are missing at least one BuildRequires
Comment 6 chris desjardins 2010-06-05 09:56:37 EDT
This should build now.

http://dl.dropbox.com/u/1501309/Fedora/R-rjags.spec
http://dl.dropbox.com/u/1501309/Fedora/R-rjags-2.1.0.4-3.fc13.src.rpm

However, this package requires a package not yet packaged in Fedora. So I think unless you're willing to try and build JAGS[1] then it won't build as it's an interface between R and JAGS. 

[1] https://bugzilla.redhat.com/show_bug.cgi?id=600467