Bug 601585
| Summary: | Review Request: perl-mime-construct - Construct/send MIME messages from the command line | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Runge <mrunge> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, opensource, pahan, ppisar, rc040203 |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-28 19:26:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 602598 | ||
| Bug Blocks: | |||
|
Description
Matthias Runge
2010-06-08 09:28:00 UTC
[mrunge@mrungexp SPECS]$ rpmlint ../SRPMS/perl-mime-construct-1.10-1.fc13.src.rpm ../RPMS/noarch/perl-mime-construct-1.10-1.fc13.noarch.rpm perl-mime-construct.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint perl-mime-construct.spec ../RPMS/noarch/perl-mime-construct-1.10-1.fc13.noarch.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is quiet. License verified from README. Despite the package contains only an executable there is no better package group than Development/Libraries. Spec files seems good for me except following items: Things to explain: CPAN presents 1.9 version only. The 1.10 is not listed. The version breaks CPAN rules (1.10 is equaled to 1.1. Version next to 1.9 should be 2.0 or 1.91). This is probably the reason why not listed on CPAN. Add comment to URL or Source0 field why tar ball is not linked from homepage, or change URL to <http://www.argon.org/~roderick/>. Things to fix: Add debian/changelog into %doc. Petr, thank you for your response. I've fixed the spec and changed URL as you suggested to <http://www.argon.org/~roderick/> Further, I've contacted the author to explain the situation CPAN vs. own release. Fiexd spec is here: Spec URL: http://www.matthias-runge.de/fedora/perl-mime-construct.spec SRPM URL: http://www.matthias-runge.de/fedora/perl-mime-construct-1.10-2.fc13.src.rpm Package approved. Thank you! New Package CVS Request ======================= Package Name: perl-mime-construct Short Description: Construct/send MIME messages from the command line Owners: mrunge Branches: F-13 CVS done (by process-cvs-requests.py). perl-mime-construct-1.10-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-mime-construct-1.10-2.fc13 perl-mime-construct-1.11-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-mime-construct-1.11-1.fc13 perl-mime-construct-1.11-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-mime-construct'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-mime-construct-1.11-1.fc13 This package was improperly reviewed: The spec file lacks to prerequisites (From build.log): ... Warning: prerequisite MIME::Types 0 not found. Warning: prerequisite Proc::WaitStat 0 not found. ... While MIME::Types exists in Fedora, Proc::WaitStat isn't. This also show in rawhide reports: http://lists.fedoraproject.org/pipermail/devel/2010-June/137922.html Forgot to mention: There are two alternatives to resolve this issue: a) Somebody (Matthias, Petr?) to submit the missing perl-Proc-WaitStat package b) This package to be removed from Fedora. perl-WaitStat is submitted and already approved. https://bugzilla.redhat.com/show_bug.cgi?id=602598 Sadly, I forgot to mark it as dependency here. If I had, this situation wouldn't happened. When cvs request is processed, I'll submit perl-WaitStat into testing resp. updates and everything should be fine. Shall I mark https://bugzilla.redhat.com/show_bug.cgi?id=602598 as dependency? (In reply to comment #12) > Forgot to mention: > > There are two alternatives to resolve this issue: > a) Somebody (Matthias, Petr?) to submit the missing perl-Proc-WaitStat package perl-Proc-WaitStat already finished review and is waiting for a CVS admin: 602598 (In reply to comment #14) > perl-Proc-WaitStat already finished review and is waiting for a CVS admin: > 602598 Thanks, for the info. I wasn't aware about this. (In reply to comment #13) > When cvs request is processed, I'll submit perl-WaitStat into testing resp. > updates and everything should be fine. After you built perl-Proc-WaitStat please edit the perl-mime-construct updates to include the perl-Proc-WaitStat builds in Bodhi. This will also ensure that both builds will be pushed to stable at the same time. > Shall I mark https://bugzilla.redhat.com/show_bug.cgi?id=602598 as dependency? I did this. Add BuildRequires: perl(MIME::Types) BuildRequires: perl(Proc::WaitStat) to perl-mime-construct.spec perl-Proc-WaitStat-1.00-2.fc13,perl-mime-construct-1.11-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Proc-WaitStat-1.00-2.fc13,perl-mime-construct-1.11-2.fc13 As you've seen, perl-mime-construct and it's dependencies are built. Thanks to everyone involved in this! perl-Proc-WaitStat-1.00-2.fc13, perl-mime-construct-1.11-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Proc-WaitStat perl-mime-construct'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Proc-WaitStat-1.00-2.fc13,perl-mime-construct-1.11-2.fc13 Package Change Request ====================== Package Name: perl-mime-construct New Branches: El-5 El-6 Owners: mrunge Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-mime-construct New Branches: EPEL7 Owners: mrunge Git done (by process-git-requests). |