Bug 602348
| Summary: | Review Request: rubygem-net-ssh - A Ruby ssh client library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shreyank Gupta <shreyankg> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ayoung, fedora-package-review, mfojtik, mtasaka, notting, tdawson |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-net-ssh-2.0.23-5.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-13 16:59:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 588406, 588446, 601633 | ||
|
Description
Shreyank Gupta
2010-06-09 16:37:13 UTC
*** Bug 588461 has been marked as a duplicate of this bug. *** Koji Build: ----------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2241198 Well, as currently CVS / koji is down, for now I will just look at your
spec file, however:
-------------------------------------------------------
%check
pushd %{buildroot}%{geminstdir}
# Run tests
rake test --trace
# Remove unnecessary files
rm -f setup.rb net-ssh.gemspec
# file-not-utf8 correction
iconv --from=ISO-8859-1 --to=UTF-8 THANKS.rdoc > THANKS.rdoc.new && \
touch -r THANKS.rdoc THANKS.rdoc.new && \
mv THANKS.rdoc.new THANKS.rdoc
popd
-------------------------------------------------------
- Well, why the lines below "rake test" are done in %check
section?
Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh-2.0.23-2.fc13.src.rpm Notes: ------ * See %changelog :-) Well,
* Test
- It seems that "rake test" does not do any test.
test/README.txt says that to execute tests actually the following
command is needed:
---------------------------------------------------------------
ruby -Ilib -Itest -rrubygems test/test_all.rb
---------------------------------------------------------------
Note:
- test/common.rb contains:
---------------------------------------------------------------
2 gem "test-unit" # http://rubyforge.org/pipermail/test-unit-tracker/2009-July/000075.html
---------------------------------------------------------------
However with ruby 1.8.x test/unit is in ruby core (i.e.
in ruby-libs rpm) and this line is not needed (for
ruby 1.8.x).
Fixed and Updated: ------------------ Spec URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh-2.0.23-3.fc13.src.rpm Koji Build: ----------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2243303 Well, I think keeping "BR: rubygem(rake)" and "rake test" lines is
safer, however not a blocker.
-------------------------------------------------------------
This package (rubygem-net-ssh) is APPROVED by mtasaka
-------------------------------------------------------------
I will update that. Meanwhile.. New Package CVS Request ======================= Package Name: rubygem-net-ssh Short Description: A Ruby ssh client library Owners: shreyankg Branches: F-13 CVS done (by process-cvs-requests.py). Fixed and Updated: ------------------ Spec URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh-2.0.23-4.fc13.src.rpm rubygem-net-ssh-2.0.23-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-net-ssh-2.0.23-5.fc13 Closing. rubygem-net-ssh-2.0.23-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. I'm willing to import this package to EPEL if you don't mind. Package Change Request ====================== Package Name: rubygem-net-ssh New Branches: el5 el6 Owners: mfojtik Git done (by process-git-requests). Package Change Request ====================== Package Name: rubygem-net-ssh New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |