Bug 602703
| Summary: | Review Request: perl-HTTP-Parser - Parse HTTP/1.1 request into HTTP::Request/Response object | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | andrea.veri, fedora-package-review, notting, paul, shakthimaan, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/HTTP-Parser/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-18 11:07:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 602674 | ||
|
Description
Petr Pisar
2010-06-10 14:17:51 UTC
Source matches. License matches. Builds in mock. No crazy provides or requires. rpmlint silent other than the spelling thing mentioned. No missing docs. Owns what it should. Note: Please drop these explicit requires. Requires: perl(HTTP::Request) Requires: perl(HTTP::Response) Requires: perl(URI) The automatic perl dep generator takes care of them. APPROVED On Fedora 13 with Perl 5.10.1, the example in the README file emits error: syntax error at /tmp/foo.pl line 9, near "while my " syntax error at /tmp/foo.pl line 12, near "}" Execution of /tmp/foo.pl aborted due to compilation errors. Can you please check? Thanks for report. Just replace the `while' with `foreach'. https://rt.cpan.org/Public/Bug/Display.html?id=58404 New Package CVS Request ======================= Package Name: perl-HTTP-Parser Short Description: Parse HTTP/1.1 request into HTTP::Request/Response object Owners: ppisar mmaslano psabata Branches: F-12 F-13 InitialCC: perl-sig I get the following output, after changing 'while' with 'foreach': $ perl foo.pl passing 'GET / HTTP/1.1' got '-2' passing 'Host: localhost' got '-2' passing 'Connection: close' got '-2' passing '' got '0' passing '' got '-2' Can't call method "as_string" without a package or object reference at foo.pl line 15. Anything is required to be included for "as_string" to function? Can you please update the README with the changes? Ok, the full working example is:
use HTTP::Parser;
my $parser = HTTP::Parser->new();
my @lines = ('GET / HTTP/1.1','Host: localhost','Connection: close','','');
my $result;
foreach my $line (@lines) {
$result = $parser->add("$line\x0d\x0a");
print "passing '$line' got '$result'\n";
}
print $parser->object->as_string();
There was missing `object' method call. Run `perldoc HTTP::Parser' for more details. The example seems be written from scratch without testing.
I will correct it in distribution package not to mislead Fedora users.
@Petr: That worked! Thanks for your prompt response! cvs done Thank you for review and CVS update. Package built for F14--12. perl-HTTP-Parser-0.05-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: perl-HTTP-Parser New Branches: el6 Owners: averi psabata InitialCC: perl-sig Git done (by process-git-requests). |