Bug 602997
Summary: | part-get-bootable gives wrong result with an unordered part layout | |||
---|---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Jinxin Zheng <jzheng> | |
Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> | |
Status: | CLOSED RAWHIDE | QA Contact: | ||
Severity: | medium | Docs Contact: | ||
Priority: | low | |||
Version: | unspecified | CC: | mbooth, virt-maint | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 603000 (view as bug list) | Environment: | ||
Last Closed: | 2011-07-13 08:57:32 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 603000 |
Description
Jinxin Zheng
2010-06-11 08:27:19 UTC
This is RHEL 5 or Fedora? We use two different code paths for two different parted outputs, although I suspect that both code paths are wrong since both assume that parted will return the partitions in order starting at 1 with no gaps. Here is the code for do_part_get_bootable: http://git.annexia.org/?p=libguestfs.git;a=blob;f=daemon/parted.c;hb=HEAD#l545 Looking at that file, it seems that only part-get-bootable should be affected by this issue. (In reply to comment #1) > This is RHEL 5 or Fedora? We use two different code paths > for two different parted outputs, although I suspect that > both code paths are wrong since both assume that parted > will return the partitions in order starting at 1 with no gaps. > I tested under fedora12,RHEL5,RHEL6, all produced.. > Here is the code for do_part_get_bootable: > > http://git.annexia.org/?p=libguestfs.git;a=blob;f=daemon/parted.c;hb=HEAD#l545 > > Looking at that file, it seems that only part-get-bootable > should be affected by this issue. Yes I see too. Please examine more carefully than I if you can. Fix pushed upstream and available in Rawhide in libguestfs >= 1.11.15. |