Bug 603245

Changes:
- renew git snapshot
- start from version 0.1 like upstream (not the version from zeromq)
- remove buildroot / %%clean

Upstream want to further think about the version naming, because they don't always do version bumps, when a new version of zeromq comes out.
Always having the version number here, which is the required version of zeromq would be the best, but I let that decision to upstream...

_______________________________________________________________________________


rpmlint:
$ rpmlint ./pyzmq-0.1.20100725git18f5d06-1.fc13.src.rpm ./x86_64/pyzmq-*
pyzmq.src: W: no-cleaning-of-buildroot %install
pyzmq.src: W: no-cleaning-of-buildroot %clean
pyzmq.src: W: no-buildroot-tag
pyzmq.src: W: no-%clean-section
pyzmq.src: W: invalid-url Source0: pyzmq-0.1.20100725git18f5d06.tar.xz
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

All of them are false positives.

_______________________________________________________________________________

koji scratch build successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2349505

koji scratch build against python 2.7 successful:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2349511

_______________________________________________________________________________


Spec URL: http://tomspur.fedorapeople.org/review/pyzmq.spec
SRPM URL: http://tomspur.fedorapeople.org/review/pyzmq-0.1.20100725git18f5d06-1.fc13.src.rpm

Hmm, there might be a license issue:

zmq/eventloop/*.py seem to be under apache, but the author says it's LGPLv3+, but I *think* this is allowed to relicense under a more restrictive license, isn't it?

Or should I use this one as License:
LGPLv3+ and ASL 2.0 ?

1)Python packages installing .so files don't need to follow http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
so remove that scriptlet from spec.

2) Please don't use more empty lines as I can see between %install and %check

3) also, I see python packaging guidelines now suggests using BR:python2-devel

4) Why do you need following in SPEC?
%global _use_internal_dependency_generator 0
%global __find_provides    %{_rpmconfigdir}/find-provides | grep -v _zmq.so

spot,
  can you help to determine what will be the license tag for this package?

The appropriate license tag should be:

License: LGPLv3+ and ASL 2.0

Lifting FE-Legal.

(In reply to comment #3)
> 1)Python packages installing .so files don't need to follow
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
> so remove that scriptlet from spec.
Done
> 2) Please don't use more empty lines as I can see between %install and %check
4 empty lines now.
> 3) also, I see python packaging guidelines now suggests using BR:python2-devel
Done
> 4) Why do you need following in SPEC?
> %global _use_internal_dependency_generator 0
> %global __find_provides    %{_rpmconfigdir}/find-provides | grep -v _zmq.so    

Because of bug #619482.

I want to disable the rpm detection of python libs, but till that is done, we need to split them away manually :(
Hopefully, that bug is fixed soon, no python libraries are detected as "Provides".

_________________________________________________________________________________

I now emit a python3- subpackage, so I renamed the program from pyzmq to python-zmq, so it's easier to distinguish between python-* and python3-*.

I needed to remove the example in the python 3 package, because 2to3 won't run on it and crash...

SPEC: http://tomspur.fedorapeople.org/review/python-zmq.spec
SRPM: http://tomspur.fedorapeople.org/review/python-zmq-0.1.20100725git18f5d06-2.fc13.src.rpm

koji build failed => http://koji.fedoraproject.org/koji/taskinfo?taskID=2380709

(In reply to comment #7)
> koji build failed => http://koji.fedoraproject.org/koji/taskinfo?taskID=2380709    

There were a missing BR for 2to3.

It builds now:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2382048

SPEC: http://tomspur.fedorapeople.org/review/python-zmq.spec
SRPM:
http://tomspur.fedorapeople.org/review/python-zmq-0.1.20100725git18f5d06-3.fc13.src.rpm

+ koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2384449
+ rpmlint output on built package is
 python-zmq.src:139: W: macro-in-comment %{buildroot}
python-zmq.src:139: W: macro-in-comment %{python3_sitearch}
==> If comments are only for temporary then its ok to keep them otherwise remove those lines from spec.
python-zmq.src: W: no-cleaning-of-buildroot %install
python-zmq.src: W: no-cleaning-of-buildroot %clean
python-zmq.src: W: no-buildroot-tag
python-zmq.src: W: no-%clean-section
python-zmq.src: W: invalid-url Source0: pyzmq-0.1.20100725git18f5d06.tar.xz
3 packages and 0 specfiles checked; 0 errors, 7 warnings.
==> Rest of these warnings are ok

- You used everywhere %{buildroot} except one place used $RPM_OPT_FLAGS"
   Please fix this


APPROVED.

IMHO, the name python-zmq don't match Fedora naming guideline, though I think the naming guideline for python modules isn't clearly enough and cause many inconsistencies in the repo.

Currently, many existed py* packages(e.g. pygtk2) are already named as python3-py*. Maybe we should adopt python modules naming guldeine from debian, which seems more clear than ours.

(In reply to comment #10)
> IMHO, the name python-zmq don't match Fedora naming guideline, though I think
> the naming guideline for python modules isn't clearly enough and cause many
> inconsistencies in the repo.

See: http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29
"""
[snip]
This makes a package name format of python-$NAME. When in doubt, use the name of the module that you type to import it in a script.
"""

The imported module is zmq -> python-zmq
If it would be pyzmq -> python-pyzmq, but it isn't.
Or what do you mean?

> Currently, many existed py* packages(e.g. pygtk2) are already named as
> python3-py*. Maybe we should adopt python modules naming guldeine from debian,
> which seems more clear than ours.    

Don't know the guidelines from debian... Maybe you could bring that up to the guidelines commitee?
http://lists.fedoraproject.org/pipermail/packaging/

Parag: Thanks for the review. 
       Any doubts to the name "python-zmq"?

(In reply to comment #9)
>  python-zmq.src:139: W: macro-in-comment %{buildroot}
> python-zmq.src:139: W: macro-in-comment %{python3_sitearch}
> ==> If comments are only for temporary then its ok to keep them otherwise
> remove those lines from spec.
This shall remember me for enabling the testsuite as soon as python3-nose is available. So this is partly temarary (don't know when nose will support python3).
> - You used everywhere %{buildroot} except one place used $RPM_OPT_FLAGS"
>    Please fix this
Done locally.

(In reply to comment #11)
> (In reply to comment #10)
> > IMHO, the name python-zmq don't match Fedora naming guideline, though I think
> > the naming guideline for python modules isn't clearly enough and cause many
> > inconsistencies in the repo.
> 
> See:
> http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29
> """
> [snip]
> This makes a package name format of python-$NAME. When in doubt, use the name
> of the module that you type to import it in a script.
> """
> 
> The imported module is zmq -> python-zmq
> If it would be pyzmq -> python-pyzmq, but it isn't.
> Or what do you mean?
> 
I really like the name python-zmq, however many times when I perform a review, I can't persuade even one submitter to change their package names. They tend to use pyzmq or even python-pyzmq.

Currently, the naming guideline for python modules is ambiguous and already cause a lot of inconsistency in fedora repo.

FYI, currently three naming scheme are used in fedora:
[1]python-[tarball_name] 
Packages of python modules (thus they rely on python as a parent) use a slightly different naming scheme. They should take into account the upstream name of the python module. This makes a package name format of python-$NAME

[2]python-[module_name]
When in doubt, use the name of the module that you type to import it in a script. 

[3]tarball_name
There is an exception to this rule. If the upstream source has "py" (or "Py") in its name, you can use that name for the package. So, for example, pygtk is acceptable. 

Personally, I like most python-modules should use python-[module_name], only a few packages should use python-[tarball_name](e.g. a tarball containing a lot of different namespace or the tarball_name is much more widely used than module_name), tarball_name should be completely forbidden.

Ok. As per written in http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29 and upstream is using py in its project name, please change package name to pyzmq.

also, I am adding Toshio for second opinion here.

tomspur is correct here -- The guidelines basically leave it to maintainer option among the listed variants with a preference for python-[module name].  Since there's a python3 version of the module as tomspur notes, python-zmq and python3-zmq makes sense.

pyzmq and python3-pyzmq or  python-pyzmq and python3-pyzmq would also be acceptable combinations but it's maintainer choice among these variants.

Thanks for being thorough.

Thank you Toshio for your quick reply. So, I think tomspur is free to choose any name as explained above.

(In reply to comment #16)
> Thank you Toshio for your quick reply. So, I think tomspur is free to choose
> any name as explained above.

Alright, I choose python*-zmq:

New Package SCM Request
=======================
Package Name: python-zmq
Short Description: Software library for fast, message-based applications
Owners: tomspur
Branches: el6 f13 f14
InitialCC:

Git done (by process-git-requests).

python-zmq-0.1.20100725git18f5d06-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-zmq-0.1.20100725git18f5d06-3.fc13

python-zmq-0.1.20100725git18f5d06-3.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/python-zmq-0.1.20100725git18f5d06-3.fc14

python-zmq-0.1.20100725git18f5d06-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-zmq'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-zmq-0.1.20100725git18f5d06-3.fc14

python-zmq-0.1.20100725git18f5d06-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

python-zmq-0.1.20100725git18f5d06-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: python-zmq
New Branches: el5
Owners: tomspur

Git done (by process-git-requests).