Bug 603267
| Summary: | Review Request: Netperf - Benchmark tool for networking. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gowrishankar Rajaiyan <grajaiya> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aquini, banerjeekaushik1, d.bz-redhat, fedora-package-review, metherid, notting, pahan, sochotni |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-29 22:26:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Gowrishankar Rajaiyan
2010-06-12 06:10:20 UTC
Few notes:
* use %configure macro, this will set proper paths automatically
* either use "make %{?_smp_mflags}" or explain why parallel builds are not possible
* why delete only README.windows and not others? Either delete/not install readme files for hpux/ovms/solaris/and the rest or install all of them without exceptions (the README.vmware~ is ok...obviously stale backup file)
* you are missing %clean phase with rm -rf $RPM_BUILD_ROOT
* netperf info file doesn't include INFO-DIR-SECTION therefore your post/preun scriptlets are moot (you also checked for existence of wrong file so they were never run). Either patch info/texi file to include proper dir section or do not even call install-info (btw normally it is better to Require "info" then "/sbin/install-info")
Hi Stanislav, I appreciate and thank you for reviewing my spec. here is the updated spec and srpm: http://gowrishankar.fedorapeople.org/spec/netperf.spec http://gowrishankar.fedorapeople.org/srpms/netperf-2.4.5-2.fc12.src.rpm Keep in mind that "rm -rf $RPM_BUILD_ROOT" is mandatory only if you plan to build the packages for EPEL or Fedora older than F-13. Actually you can dump the whole clean section for F13+ and EL6+. It's useful (well, actually mandatory) to run rpmlint and look at the output: netperf.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/netperf-2.4.5/README.windows Needs fixing, assume that there's any point at all in including this file. netperf.x86_64: E: info-files-without-install-info-postin /usr/share/info/netperf.info.gz netperf.x86_64: E: info-files-without-install-info-postun /usr/share/info/netperf.info.gz You need to follow http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo if your package includes texinfo documentation. Hello Gowrishankar, Are you still interested in getting netperf into Fedora packages? If yes, please consider Jason observations and submit a new bumped-release .spec & srpm. Do you have a FAS account? As I couldn't find your email in Fedora Packager CVS Commit Group (packager), I have assumed you do not have an account, and you must get one before you proceed: http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account Also, if this is your first package review request, you gonna need a member sponsorship in order to check in and build your package, after get your work reviewed. http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored I'll be glad in helping you out. Best regards Aquini |