Bug 603269

Created attachment 423896 [details]
patch to make rake test succeed

Some notes:

* ruby(abi) dependency
  - ruby module packages must have "R: ruby(abi) = 1.8".
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* %prep, %build section:
  - From rpmlint
----------------------------------------------------------------
$ rpmlint -I 'no-%prep-section'
no-%prep-section:
The spec file does not contain a %prep section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality.  Add the section, even if
empty.
----------------------------------------------------------------
    i.e. (in the future) rpmbuild may do some additional needed procedure
    before the contents written in %prep or %build begins.

    So even if currently %prep or %build can be empty, please add them.

* %check
  - Doing "rake test" needs the attached patch.
    ( I guess that (although I have not checked it in detail)
      rdoc/task is in ruby 1.9. On Fedora rdoctask is in rake gem anyway )

* %doc in -doc subpackage
  - I think %doc attribute in -doc subpackage is redundant because
    rpm's name already shows that this is for documentation.

! macros in comments
------------------------------------------------------------------
#export PATH=$PATH:%{buildroot}%{geminstdir}/lib/plist
#export LD_LIBRARY_PATH=$PATH:%{buildroot}%{geminstdir}/lib
....
------------------------------------------------------------------
  - These comment lines include macros and rpmlint warns for these:
------------------------------------------------------------------
rubygem-plist.src:51: W: macro-in-comment %{buildroot}
rubygem-plist.src:51: W: macro-in-comment %{geminstdir}
------------------------------------------------------------------

    The reason rpmlint warns for "macro-in-comment" is that
    during rpmbuild macros are expanded anyway, even in comment lines.
    For this package this is safe, however if a defined macro contains
    several lines, this can cause some strange behavior.
    - For example, with "#%configure", configure script is executed
      against expectation

    So it is always recommended to excape macros in comment lines
    using %% instead of %.

old SPEC file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec.1

current Spec file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec
current SRPM URL: 
ftp://ftp.uni-siegen.de/pub/review/rubygem-plist-3.1.0-2.fc12.src.rpm

current scratch-build-URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2250832


Test output (also added as comment in the SPEC file):

...
+ ruby test
ruby: Is a directory - test (Errno::EISDIR)
...

I have not checked your srpm, however:

(In reply to comment #1)
> * %check
>   - Doing "rake test" needs the attached patch.

The tests finishes successful.

old SPEC file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec.2

current Spec file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec
current SRPM URL: 
ftp://ftp.uni-siegen.de/pub/review/rubygem-plist-3.1.0-3.fc12.src.rpm

current scratch-build-URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2252136

For -2:

* For plist.patch
  - As this is a patch, please use "Patch0" instead of "Source1"
  - And please consider to rename this to something which indicates
    what this patch is for, and also write some comments
    about this patch briefly.

* Comments in %check
  - Please remove comments which are no longer needed
    ( ruby test or so is no longer needed )

* Fallback in %check
  - I don't think "|| :" after rake test is needed any longer.

* %doc in -doc
  - Well, I don't think you have to add %doc in -doc just to
    suppress rpmlint warnings.

- use "Patch0" instead of "Source1" as tag for the patch
- add comments about the patch and rename the file

The rest was already done in release 3 of the spec file.

old SPEC file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec.3

current Spec file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec
current SRPM URL: 
ftp://ftp.uni-siegen.de/pub/review/rubygem-plist-3.1.0-4.fc12.src.rpm

current scratch-build-URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2253763

Well, -4:
-------------------------------------------------------------
   83  #  E: non-executable-script  (for *.rb files)
-------------------------------------------------------------
- This is because scripts under test/ dierctory have shebangs
  but does not have executable permission.

  Since these scripts need not have shebangs, simply remove
  shebangs from these scripts (under test/).

done.

old SPEC file URL: ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec.4

current (release 5) Spec file at URL:
ftp://ftp.uni-siegen.de/pub/review/rubygem-plist.spec

current SRPM URL: 
ftp://ftp.uni-siegen.de/pub/review/rubygem-plist-3.1.0-5.fc12.src.rpm

current scratch-build-URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2256589

Okay.

-----------------------------------------------------------
    This package (rubygem-plist) is APPROVED by mtasaka
-----------------------------------------------------------

Thank you for the patch and the review!

New Package CVS Request
=======================
Package Name: rubygem-plist
Short Description: All-purpose Property List manipulation
Owners: gerd
Branches: F-12 F-13
InitialCC: gerd

CVS done (by process-cvs-requests.py).

rubygem-plist-3.1.0-5.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/rubygem-plist-3.1.0-5.fc13

rubygem-plist-3.1.0-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-plist-3.1.0-5.fc12

rubygem-plist-3.1.0-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-plist-3.1.0-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.