Bug 603629
| Summary: | Review Request: cf-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Pravin Satpute <psatpute> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, psatpute |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | Flags: | psatpute:
fedora-review+
petersen: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-09 14:02:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Parag Nemade
2010-06-14 08:24:18 UTC
- package installed properly.
1) please check .conf file
<family>OFL Sorts Mill Goudy</family>
it should be <family>Sorts Mill Goudy</family>
+ package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2277636 + rpmlint is silent for SRPM and for RPM. cf-sorts-mill-goudy-fonts.src: W: no-buildroot-tag -> no need for it now cf-sorts-mill-goudy-fonts.src: W: uncompressed-zip goudy-3.0.zip -> please check this cf-sorts-mill-goudy-fonts.noarch: W: obsolete-not-provided ofl-sorts-mill-goudy-fonts -> this is ok, since build happen only in devel + source files match upstream url 50520a9636ae999f2f72cb2b5f41b147 goudy-3.0.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/cf-sorts-mill-goudy-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/cf-sorts-mill-goudy-fonts-3.0-2.fc13.src.rpm I have fixed conf file but not bumped release. + approved Thanks for the review! New Package CVS Request ======================= Package Name: cf-sorts-mill-goudy-fonts Short Description: Goudy Oldstyle and Italic fonts Owners: pnemade Branches: InitialCC: i18n-team fonts-sig CVS done (by process-cvs-requests.py). Package Change Request ====================== Package Name: cf-sorts-mill-goudy-fonts New Branches: el6 epel7 Owners: pnemade Git done (by process-git-requests). |