Bug 603641
| Summary: | Review Request: python-fontMath - A set of objects for performing math operations on font data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, tomspur |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | Flags: | tomspur:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-26 06:06:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 603634 | ||
| Bug Blocks: | |||
|
Description
Parag Nemade
2010-06-14 08:47:40 UTC
Following python naming guidelines. Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-fontMath.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-fontMath-0.2-1.fc13.src.rpm Review:
Good:
- name ok
- source match upstream: 739ecc87c553180c4978c110230be6f7
- $ rpmlint ./python-fontMath-0.2-1.fc13.src.rpm noarch/python-fontMath-0.2-1.fc13.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- no libs
- no locales
- license ok
- macros everywhere
- spec readable
Needswork:
- you should use %{version} in the source url
- you should also buildrequire python-robofab
- wouldn't be Development/Tools be better as a group?
- %files:
You don't own %{python_sitelib}/fontMath -> remove the '*'
_____________________________________________________________________________
the %files issue is a blocker, the rest SHOULD.
Approving anyway, because I'm sure, you'll change it.
_____________________________________________________________________________
APPROVED
Updated package as Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-fontMath.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-fontMath-0.2-2.fc13.src.rpm But, Do I really need to BR:python-robofab? See successful koji scratch build without it http://koji.fedoraproject.org/koji/taskinfo?taskID=2340303 (In reply to comment #3) > But, Do I really need to BR:python-robofab? > > See successful koji scratch build without it > http://koji.fedoraproject.org/koji/taskinfo?taskID=2340303 Long answer: Currently the setup.py is complaining with: + /usr/bin/python setup.py build *** Warning: defcon requires RoboFab, see: robofab.com see: http://koji.fedoraproject.org/koji/getfile?taskID=2340304&name=build.log So it would be better to also BuildRequire it. For now it's not needed, only if they choose to add a testsuite and you want to run it. I'd feel just saver with adding it now, so upstream can change what they want. (but no blocker throught) Short answer: no :) Thanks. I will add it when I will import it in cvs and also will add it in other packages. Thanks for the review! New Package CVS Request ======================= Package Name: python-fontMath Short Description: A set of objects for performing math operations on font data Owners: pnemade Branches: F-13 EL-6 InitialCC: i18n-team fonts-sig CVS done (by process-cvs-requests.py). Built in rawhide. awaiting for fonttools in EPEL6 which will allow to build python-robofab and then this package in EPEL6. |