Bug 604033
Summary: | Review Request: openemr - Practice Management, Electronic Medical Record | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rakesh Pandit <rpandit> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 13 | CC: | david, fedora-package-review, notting, sanjay.ankur |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | StalledSubmitter | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-06-27 18:15:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 673841 |
Description
Rakesh Pandit
2010-06-15 08:48:44 UTC
This package has a very large number of rpmlint complaint (script-without-shebang, wrong-script-end-of-line-encoding, non-executable-script, zero-length, etc.). You should run rpmlint on your packages and address the output when you submit your reviews. The packages build but do not install: Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::IS) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::IC) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::User) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::CT) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(sql-ledger.conf) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::Form) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::AA) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::AR) Error: Package: openemr-3.2.0-1.fc15.noarch (/openemr-3.2.0-1.fc15.noarch) Requires: perl(SL::HR) Shouldn't this have a dependency on php-mysql? How does it interface with the database otherwise? The documentation is half of the size of the package; you should probably consider splitting a separate -doc package unless the documentation is somehow required to be installed for the package to work. The package bundles some javascript libraries. Bundled javascript is generally permitted, but you must take care of the licensing issues which result. For example, DocumentTreeMenu.js has a BSD license, and there is LGPLv2+ code in calendar_nikki.inc. Since these files survive intact in the final packages, their licenses must be accounted for. You'll probably need to do a full check of all the files in the package to determine their licenses. Will update in Jan first week. Rakesh: Just another ping. In addition to tibbs comments above, this package (as almost all web apps do) bundles a ton of php libraries. Brief perusal yiels php-adodb, phpmyadmin, php-Smarty and others, though it wouldn't strike me as odd to find that number far higher. That of course needs to be rectified as bundled libraries aren't permitted. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries This message is a reminder that Fedora 13 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 13. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '13'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 13's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 13 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Hi Rakesh, Would you continue to work on this? If you don't intend to, please close the ticket so that someone can open a new one. There's a needinfo requested already. Thanks, Ankur (In reply to comment #5) > Hi Rakesh, > > Would you continue to work on this? If you don't intend to, please close the > ticket so that someone can open a new one. > > There's a needinfo requested already. > > Thanks, > Ankur I work on this and other package this weekend. In case I don't show up by 26th will close it. Fedora 13 changed to end-of-life (EOL) status on 2011-06-25. Fedora 13 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. Closed. I'll update the trac. *** This bug has been marked as a duplicate of bug 730691 *** |