Bug 604227
| Summary: | Review Request: gnome-screensaver-iv-scr-en-ru - GNOME Screensaver Slideshow of English irregular verbs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Serguei Shimansky <englishextra> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED INSUFFICIENT_DATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | bruce, fedora-package-review, msuchy |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://shimansky.biz/pages/products_sourceforge_iv-scr-en-ru.html | ||
| Whiteboard: | NotReady | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-08-21 09:12:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Serguei Shimansky
2010-06-15 16:42:00 UTC
Here's an informal review: The spec's layout is rather messy, it should conform to the template. https://fedoraproject.org/wiki/Packaging/Guidelines#Writing_a_package_from_scratch The Release should contain %{dist} https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag The BuildRoot tag is no longer required https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag rm -rf $RPM_BUILD_ROOT is not required in %install any more https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag %clean is no longer required https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean There is no changelog https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs Thank you, Bruce -- will reconsider all notes Was there ever any response to the commentary? I think this is a good idea for a package, but honestly, isn't there a better way to do it than by having a bunch of images? Perhaps take a few backgrounds and have the screensaver itself print the text on them? You could take the various words and translations from a text file, and it wouldn't even have to be language-specific. Oh yes. Might be released using XML. Thanks for the hint. Will have to think this over. As far as I can see, the current gnome-screensaver won't work with your package. It would be applicable for EPEL 5/6 only. Is it intended to go into these branches? Or are you actually still interested to keep this review request alive? No response for years. Closing. Feel free to reopen if you want to continue. |