Bug 604500
| Summary: | Review Request: ibus-input-pad - Input Pad for IBus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fujiwara <tfujiwar> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, panemade |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
petersen: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ibus-input-pad-0.1.0.20100630-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-07 17:38:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
fujiwara
2010-06-16 04:33:04 UTC
Any sponsors? Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261364 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz fa51b69bd89a53e821b30002287c62eadcaccb66 ibus-input-pad-0.1.0.20100611.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) %description should be The input-pad engine for IBus platform. 2) Like all other ibus-* engines in Fedora, this should Requires: ibus 3) you don't need following BuildRequires: pkgconfig See a successful koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2261603 without it. APPROVED. fujiwara is in need of some explanations for above suggestions. therefore I am revoking approval as he seems not satisfied with my suggestions specifically on 2nd suggestion. After I investigated 2) suggestion, I found ibus-libs doesn't have the dependency of ibus. Now I accepted the 2) suggestion. 1) and 3) seem recommendations but not requirements in Fedora packaging. http://fedoraproject.org/wiki/PackagingGuidelines#Pkgconfig_Files Updated the spec file: http://github.com/fujiwarat/ibus-input-pad/commit/09563be22d1936b1966c19a52b765621beb05a71 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/ibus-input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/ibus-input-pad-0.1.0.20100611-2.fc13.src.rpm Thanks for understanding suggestions. I am getting mixed replies on fedora-devel channel and fedora packaging mailing list like removing BR: pkgconfig is not creating any harm and someone said we should have it. I am approving new SRPM. If someone sees any problem, please report here. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2266521 APPROVED. New Package CVS Request ======================= Package Name: ibus-input-pad Short Description: Input Pad for IBus Owners: fujiwara Branches: F-12 F-13 InitialCC: i18n-team cvs done Thanks for this! Most interfaces are committed. http://koji.fedoraproject.org/koji/taskinfo?taskID=2282442 I'll integrate this in f12/f13 tomorrow. http://koji.fedoraproject.org/koji/taskinfo?taskID=2288658 http://koji.fedoraproject.org/koji/taskinfo?taskID=2288662 ibus-input-pad-0.1.0.20100630-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc13 ibus-input-pad-0.1.0.20100630-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc12 ibus-input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc13 ibus-input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ibus-input-pad-0.1.0.20100630-1.fc12 ibus-input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. ibus-input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |