Bug 604653
| Summary: | Review Request: perl-Test-NoTabs - Check the presence of tabs in your project | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-NoTabs-1.0-3.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-24 16:29:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 604659 | ||
|
Description
Paul Howarth
2010-06-16 12:26:15 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261130 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) c76ac17b0988488f5b3a757fc119a8f2c8d6218e Test-NoTabs-1.0.tar.gz.srpm c76ac17b0988488f5b3a757fc119a8f2c8d6218e Test-NoTabs-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=16, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.48 cusr 0.07 csys = 0.58 CPU) + Package perl-Test-NoTabs-1.0-3.fc14.noarch => Provides: perl(Test::NoTabs) = 1.0 Requires: perl(File::Find) perl(File::Spec) perl(FindBin) perl(Test::Builder) perl(strict) perl(vars) perl(warnings) + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-Test-NoTabs Short Description: Check the presence of tabs in your project Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). perl-Test-NoTabs-1.0-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.fc13 perl-Test-NoTabs-1.0-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.fc12 perl-Test-NoTabs-1.0-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.el5 perl-Test-NoTabs-1.0-3.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.el4 perl-Test-NoTabs-1.0-3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Test-NoTabs'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.el5 perl-Test-NoTabs-1.0-3.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Test-NoTabs'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Test-NoTabs-1.0-3.el4 perl-Test-NoTabs-1.0-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-NoTabs-1.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-NoTabs-1.0-3.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-NoTabs-1.0-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |