Bug 605336

Summary: bundle deploy wizard "previous" button support is broken
Product: [Other] RHQ Project Reporter: John Mazzitelli <mazz>
Component: ProvisioningAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Sunil Kondkar <skondkar>
Severity: medium Docs Contact:
Priority: urgent    
Version: 3.0.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 2.4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-12 16:47:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 577210    

Description John Mazzitelli 2010-06-17 16:37:11 UTC
go to the deploy wizard, enter the destination info, get to the next step, hit the previous button, hit the next button, get this error:

org.hibernate.exception.ConstraintViolationException:Could not execute JDBC batch update -> java.sql.BatchUpdateException:Batch entry 0 insert into RHQ_BUNDLE_DESTINATION (NAME, DESCRIPTION, DEPLOY_DIR, CTIME, MTIME, BUNDLE_ID, GROUP_ID, ID) values ('home', NULL, '/home/mazz/tmp/deleteme', '1276792430528', '1276792430528', '10001', '10001', '10002') was aborted. Call getNextException to see the cause.[SQLException=Batch entry 0 insert into RHQ_BUNDLE_DESTINATION (NAME, DESCRIPTION, DEPLOY_DIR, CTIME, MTIME, BUNDLE_ID, GROUP_ID, ID) values ('home', NULL, '/home/mazz/tmp/deleteme', '1276792430528', '1276792430528', '10001', '10001', '10002') was aborted. Call getNextException to see the cause. -> ERROR: duplicate key value violates unique constraint "rhq_bundle_destination_unique"(error-code=0,sql-state=23505)]

the wizard should know that it already created the destination and should not try to create it again. note that since it seems the destination is created on "next" and not at the end on "finish", the "cancel" button needs to ensure that it deletes the destination if one was created.

we need to test the previous button on each step and make sure that it can be cleaned up after a cancel as well as being able to finish if the steps go on to full completion.

Comment 1 Jay Shaughnessy 2010-06-21 18:58:55 UTC
fix commit: e24f75a56fa6dabe7ee32216dd5d27b83c1e8834

allow repeated execution of the get destination step.

Comment 2 Sunil Kondkar 2010-06-29 11:36:37 UTC
Verified on JON 2.4 GA_QA build

On deploy wizard clicked on 'Previous' and 'Next' buttons as well as on 'Cancel' button on each step. Also verified that clicking on 'Finish' button completes the deployment.
No exception is observed.

Comment 3 Corey Welton 2010-08-12 16:47:09 UTC
Mass-closure of verified bugs against JON.