Bug 605610
| Summary: | Review Request: rubygem-chronic - natural language date/time parser written in pure Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shreyank Gupta <shreyankg> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-02 07:44:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Shreyank Gupta
2010-06-18 11:45:18 UTC
For 0.2.3-1
* (Build)Requires
- Build fails without additional "BR: rubygem(rake), rubygem(hoe)"
- On the other hand, while installed gemspec file says rubygem(hoe)
is needed for Requires, however as far as I checked the codes,
hoe is needed in Rakefile and hoe does not seem to be needed on
runtime.
I think hoe dependency can be removed from installed gemspec and
"R: rubygem(hoe)" can be removed.
* Test related issue
- Would you check if the (ignored) test failure and warnings can
really be ignored?
- Especially I think that it is better that you fix the warning
of "warning: instance variable @foo not initialized".
- Well, it may be more readable and preferable to create a patch rather
than to specify the lines to be deleted by sed, however not a blocker.
Updated: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/chronic/rubygem-chronic.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/chronic/rubygem-chronic-0.2.3-2.fc13.src.rpm Notes: ------ * See ChangeLog * I contacted the upstream, he is not replying w.r.t the warnings and errors. Personally I guess the warnings can be ignored as they are mostly about uninitialised variables. Also the failures are few in the stable version up for packaging, and more in number in the git snapshot. I guess we need to overlook that if we want to package this for Fedora. * I intentionally did not create a patch because I do not want to maintain another source file for test failures. Koji Scratch Build: ------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2280329 Updated Koji Scratch Build: --------------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2280492 Don't know why the last one failed. Well, once test_parse_guess_dates failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=2280925 however, on the next trial scratch build, this test succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=2280981 Not sure what is happening here, however I won't think this is a blocker. ------------------------------------------------------------- This package (rubygem-chronic) is APPROVED by mtasaka ------------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-chronic Short Description: natural language date/time parser written in pure Ruby Owners: shreyankg Branches: F-13 CVS done (by process-cvs-requests.py). rubygem-chronic-0.2.3-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-chronic-0.2.3-2.fc13 rubygem-chronic-0.2.3-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-chronic'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-chronic-0.2.3-2.fc13 Closing. |