Bug 605719
| Summary: | Review Request: mesa-demos - mesa opengl demos | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jérôme Glisse <jglisse> |
| Component: | Package Review | Assignee: | Adam Jackson <ajax> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, supercyper1 |
| Target Milestone: | --- | Flags: | ajax:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-28 13:32:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jérôme Glisse
2010-06-18 15:44:56 UTC
Package name can be different, we already have a mesa-demos package but to reflect the change upstream we would like to split the demo from mesa. Maybe we can epoch current mesa-demos or depreciate current mesa-demos and rename this package to a new name like mesa-gl-demos Updated spec & rpm based on lastest upstream release http://people.freedesktop.org/~glisse/mesa-demos/mesa-demos-8.0.1-1.src.rpm http://people.freedesktop.org/~glisse/mesa-demos/mesa-demos.spec Taking for review. * rpmlint output on src rpm is mostly harmless:
mesa-demos.src: W: no-version-in-last-changelog
mesa-demos.src: W: strange-permission mesad-git-snapshot.sh 0755L
mesa-demos.src:1: W: macro-in-comment %define
mesa-demos.src:16: W: macro-in-comment %{tarball}
mesa-demos.src:16: W: macro-in-comment %{gitdate}
mesa-demos.src:41: W: macro-in-comment %setup
mesa-demos.src:41: W: macro-in-comment %{tarball}
mesa-demos.src:41: W: macro-in-comment %{gitdate}
glx-utils.x86_64: W: no-version-in-last-changelog
glx-utils.x86_64: W: no-manual-page-for-binary glxgears
glx-utils.x86_64: W: no-manual-page-for-binary glxinfo
mesa-demos.x86_64: W: no-version-in-last-changelog
mesa-demos.x86_64: W: no-documentation
mesa-demos-debuginfo.x86_64: W: no-version-in-last-changelog
3 packages and 0 specfiles checked; 0 errors, 6 warnings.
Please do attach a version number to the changelog before building into koji.
* Naming matches upstream, guidelines, and existing mesa-demos package.
* Spec file correctly named
* Meets Packaging Guidelines. Most of mesa-demos is under %{_libdir}/mesa to avoid conflicts with other packages, since there's a very large number of demos. This matches xscreensaver, for example.
! Meets Licensing Guidelines, in that MIT is fine, but does not include the COPYING file in %doc. Upstream doesn't appear to list one though.
* Builds in mock on x86_64.
* Owns the directory it creates.
* Does not install a desktop file, but should not; these are demo and debug tools, not real applications.
* Does not install manual pages, but upstream does not provide any.
Package is approved. Please work with upstream to include an appropriate COPYING file in the source, but looks good otherwise.
And, obviously, please disable mesa-demos from the main mesa package before importing this. New Package CVS Request ======================= Package Name: mesa-demos Short Description: mesa demos program Owners: Jerome Glisse Branches: F-14 InitialCC: ajax airlied I am likely not yet sponsored Yeah, I don't see you in the packager group yet. Please get that fixed up and then reset the fedora-cvs flag. I'm going to go ahead and sponsor Jerome. New Package CVS Request ======================= Package Name: mesa-demos Short Description: mesa demos program Owners: Jerome Glisse Branches: F-14 InitialCC: ajax airlied CVS done (by process-cvs-requests.py). Built in rawhide. |