Bug 605784
| Summary: | Review Request: googlecl - Command line tools for the Google Data APIs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Goode <adam> |
| Component: | Package Review | Assignee: | Chen Lei <supercyper1> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 11 | CC: | chkr, fedora-package-review, leifer, lemenkov, notting, pahan, rickrich, sspreitzer, supercyper1, tajidinabd |
| Target Milestone: | --- | Flags: | supercyper1:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-21 14:20:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Goode
2010-06-18 18:37:37 UTC
Some suggestion: 1. BR: python-gdata is not needed 2. Please do not gzip manpage by hand, rpmbuild will do it automatically. Ok, I have updated with these 2 changes. Spec URL: http://agoode.fedorapeople.org/googlecl.spec SRPM URL: http://agoode.fedorapeople.org/googlecl-0.9.5-2.fc14.src.rpm 1.rpmlint googlecl-0.9.5-2.fc14.src.rpm
googlecl.src: W: no-cleaning-of-buildroot %install
googlecl.src: W: no-cleaning-of-buildroot %clean
googlecl.src: W: no-buildroot-tag
googlecl.src: W: no-%clean-section
%clean section is still needed for F12
2.You still need those macros for building rpm in F12:
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
3. you can add changlog to %doc
Except those trival issue, the package is fine.
Ok, I have updated with these 3 changes, thanks. Spec URL: http://agoode.fedorapeople.org/googlecl.spec SRPM URL: http://agoode.fedorapeople.org/googlecl-0.9.5-3.fc14.src.rpm Okay, this package is approved. New Package CVS Request ======================= Package Name: googlecl Short Description: Command line tools for the Google Data APIs Owners: agoode Branches: F-12 F-13 EL-5 EL-6 InitialCC: 0.9.7 is released Please do a "noarch" for everybody including fc10, fc11, etc... and NOT fc12, f13, etc. From the site: "GoogleCL is a pure Python application". (In reply to comment #7) > 0.9.7 is released Ok, thanks. (In reply to comment #8) > Please do a "noarch" for everybody including fc10, fc11, etc... and NOT fc12, > f13, etc. From the site: > Sorry, this is not allowed: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#New_Packages You may be able to rebuild the packages yourself from the SRPM. *** Bug 606146 has been marked as a duplicate of this bug. *** CVS done (by process-cvs-requests.py). Added Review Request reference to Packaging Wishlist Wiki page. https://fedoraproject.org/wiki/Package_maintainers_wishlist#E-G *** Bug 611711 has been marked as a duplicate of this bug. *** |