Bug 605816
| Summary: | [RHEL 5.6] move Tausworthe net_random generator to lib/random32 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Jarod Wilson <jarod> | ||||||
| Component: | kernel | Assignee: | Jarod Wilson <jarod> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.6 | CC: | adaora.onyia, andriusb, bugproxy, bzeranski, cward, jjarvis, joseph.mann, laurie.barry, martinez, nobody+PNT0273897, plyons, revers, sandy.garza, sbest, vaios.papadimitriou | ||||||
| Target Milestone: | rc | Keywords: | FutureFeature, OtherQA | ||||||
| Target Release: | 5.6 | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-01-13 21:38:34 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 557597, 564513, 571862 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jarod Wilson
2010-06-18 20:44:24 UTC
Commit aaa248f6c9c81b2683db7dbb0689cd5ed1c86d88 upstream (pre-2.6.19) renamed and moved the net_random interface from net/core/utils.c to random32 in lib/random32.c. The lpfc driver uses the random32 interface, and thus we should properly backport it in the RHEL5 kernel. Jarod, Can you post the patch on this bz so Emulex has access to it until they can get a build with this code in it? Thanks, Rob (In reply to comment #2) > Jarod, > > Can you post the patch on this bz so Emulex has access to it until they can get > a build with this code in it? Yep, will do, as soon as I have a patch together, hopefully early next week... So this patch will also need to be provided in the DUP, Rob? (In reply to comment #4) > So this patch will also need to be provided in the DUP, Rob? Given the timing constraints of delivering the DUP, Jarod and I agree to take the original patch for the DUP and the backport here will not be required. Jarod will backport the functionality and Emulex is encouraged to update the lpfc driver to eliminate what will be redundant code when the backport is complete. Initial backport is done, throwing it into a test build momentarily, and assuming that works, I'll tack the patch onto this bz and post it for internal review. Created attachment 426078 [details]
random32 support backport to rhel5
Matches current (2.6.35-rc3) lib/random32.c and accompanying code as closely as possible, with only minor deviations for context differences, and a need to preserve the net_random and net_srandom kabi symbols.
Created attachment 426079 [details]
port lpfc driver to use kernel-provided random32
This patch applies atop the lpfc patches submitted under bugzilla #591674 and bugzilla #571862, and adapts the lpfc driver to use the kernel-provided random32 functions from the other patch posted in this bug.
The patch looks good. We will update our LPFC driver based on this patch. Based on this LPFC driver patch and the comments from Comment 8, is there any additional information needed from Emulex as far as BZ #591674 and #571862 are concerned? Do you need a separate Emulex LPFC driver patch that takes into account removing the random32 defines or the patch from Comment 8 will be sufficient? (In reply to comment #9) > The patch looks good. We will update our LPFC driver based on this patch. > > Based on this LPFC driver patch and the comments from Comment 8, is there any > additional information needed from Emulex as far as BZ #591674 and > #571862 are concerned? Do you need a separate Emulex LPFC driver patch that > takes into account removing the random32 defines or the patch from Comment 8 > will be sufficient? The random32 addition in comment #7 and the lpfc modifications in comment #8 have already been posted for internal review, so no need for Emulex to post anything else at this time. What we could definitely use is testing feedback from Emulex when running with these two patches applied, just to confirm that we're not breaking anything with this change. If we run into issues when testing, then we may need help from Emulex fixing any regressions caused by these patches, but they actually get us much closer to upstream, so I'm fully anticipating everything will be just fine, and all we really need is the thumbs up from Emulex. (In reply to comment #9) > The patch looks good. We will update our LPFC driver based on this patch. > > Based on this LPFC driver patch and the comments from Comment 8, is there any > additional information needed from Emulex as far as BZ #591674 and > #571862 are concerned? Do you need a separate Emulex LPFC driver patch that > takes into account removing the random32 defines or the patch from Comment 8 > will be sufficient? Both the BZ #591674 and #571862 patches have been posted and no other info is required from Emulex for these updates. in kernel-2.6.18-211.el5 You can download this test kernel from http://people.redhat.com/jwilson/el5 Detailed testing feedback is always welcomed. ~~ Attention Customers and Partners - RHEL 5.6 Public Beta is now available on RHN ~~ A fix for this 'OtherQA' BZ should be present and testable in the release. If this Bugzilla is verified as resolved, please update the Verified field above with an appropriate value and include a summary of the testing executed and the results obtained. If you encounter any issues or have questions while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patches to request for inclusion, promptly escalate the new issues through your support representative. Finally, future Beta kernels can be found here: http://people.redhat.com/jwilson/el5/ Note: Bugs with the 'OtherQA' keyword require Third-Party testing to confirm the request has been properly addressed. See: https://bugzilla.redhat.com/describekeywords.cgi#OtherQA ). Reminder! There should be a fix present for this BZ in snapshot 3 -- unless otherwise noted in a previous comment. Please test and update this BZ with test results as soon as possible. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0017.html |