Bug 605821

Summary:	ant launcher invoker deployer multiple times
Product:	[Other] RHQ Project	Reporter:	John Mazzitelli <mazz>
Component:	Provisioning	Assignee:	Ian Springer <ian.springer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Corey Welton <cwelton>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	3.0.0	CC:	ccrouch
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	2.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-12 16:52:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	577210

Description John Mazzitelli 2010-06-18 20:58:32 UTC

AntLauncher calls ProjectHelper.configureProject() which is causing the BundleTask to call the Deployer (because BundleTask.execute is executed). Then later on, AntLauncher invokes the "" target which also invokes the Deployer.

This means we deploy twice, which is bad.

org.rhq.plugins.ant.AntBundlePluginComponentTest.testAntBundleTwo()

is a unit test that can illustrate this. I commented out the assert so Hudson doesn't fail this build right now (its in the release-3.0.0 branch), but to see this test fail, uncomment this assert:

// TODO: uncomment once we fix the problem that ant launcher invokes the deploy multiple times
//assert previousProps == null : "There should not be any previous deployment metadata";

Comment 1 John Mazzitelli 2010-06-21 20:51:48 UTC

i'm putting additional tests for upgrade, clean upgrade and revert testing.

Each has some lines commented out until this BZ is fixed. Once this is fixed, uncomment the lines in the test and confirm they pass. If they pass, this BZ should be considered fixed and ready for QA.

The comments to look for is this (they appear several times):

// TODO: uncomment once we fix the problem that ant launcher invokes the deploy multiple times

Comment 2 Ian Springer 2010-06-23 01:42:15 UTC

This is fixed by commit a75768dea4dd93403c2711838d0bc87262edee0c and has been pushed to the release-3.0.0 branch.

Comment 3 Corey Welton 2010-06-24 13:03:25 UTC

QA Closing.  This is basically a code change covered by unit tests.

Comment 4 Corey Welton 2010-08-12 16:52:23 UTC

Mass-closure of verified bugs against JON.