Bug 606003
| Summary: | Review Request: pypolicyd-spf - SPF Policy Server for Postfix | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Zemlyak <zart> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | fedora-package-review, felix, mrunge, notting, trever, zart | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | StalledSubmitter | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-03-24 18:19:39 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Konstantin Zemlyak
2010-06-19 21:51:11 UTC
Note that you can remove the %{?fedora} > 12 conditional; F13 is the oldest thing you can build for. There were also updated Python guidelines which you should read over. The python3 stuff probably has no bearing on this package, but you will at least need BuildRequires: python2-devel instead of python-devel.
Thanks for reviewing.
I've updated package to version 0.8.1 released few days ago. Spec has been updated to use python2-devel and %{}-style for consistency. I'll keep %{?fedora} > 12 for now since I'm still running f12 myself.
http://aura.zartsoft.ru/~zart/fedora/ has both src and noarch rpms from koji's scratch builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2638340
http://koji.fedoraproject.org/koji/taskinfo?taskID=2638385
http://koji.fedoraproject.org/koji/taskinfo?taskID=2638409
any progress here? Anyone still interested in this and willing to help if I get a spec file started? Feel free to reuse my .spec files at http://feena.zartsoft.ru/~zart/fedora/ Created attachment 746539 [details]
intial shot at a spec file
Thank you. I appreciate this. Any reason you stopped working on this? I thought I've finished the spec, but probably didn't follow up release process properly so it stuck at "StalledSubmitter" stage. I didn't have time and interest to pursue it further since rpm worked for me just fine. My mailserver has been using that rpm for few years now without issues. I had a look at your version of spec and have got few questions:
- why both python-devel and python2-devel? also judging by setup.py in 1.1.2 it's now 3.2+ compatible
- Since it's postfix-specific package, why you didn't put postfix in Requires? Installing this package without postfix doesn't make sense.
- python-setuptools is not strictly required since it's pure distutils package.
- Shouldn't %{_sysconfig} files be marked as %config(noreplace)? Also why mark them as executable with 0755?
*** This bug has been marked as a duplicate of bug 921797 *** Konstantin, some of that was copied from other spec files I copied from or from the python-spf package. Thank you for pointing some of these things out. I am going to fix several of my other packages now. |