Bug 606064
| Summary: | Review Request: libfc14audiodecoder - C wrapper library for Future Composer audio decoding | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Schwendt <bugs.michael> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, michel, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-26 10:40:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Schwendt
2010-06-20 10:27:17 UTC
Everything looks in good shape. APPROVED * DONE Review [100%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream sha1sum: f11f7aff4f59c669a07a5f3481cb69505270b008 ** DONE License [3/3] *** DONE License is Fedora-approved *** DONE License field accurate all C++ source files have the "later version" provision *** DONE License included iff packaged by upstream ** DONE rpmlint [2/2] *** DONE on src.rpm libfc14audiodecoder.src: E: unknown-key GPG#b8af1c54 -> private signing key, ignoring "error" libfc14audiodecoder.src: W: no-buildroot-tag -> fine for F-13+ *** DONE on x86_64.rpm Spurious warnings from rpmlint spellcheck; can be ignored ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2271926 *** DONE BRs complete *** DONE Directory ownership ** DONE Spec inspection [8/8] *** DONE ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install 2*** DONE Macro usage consistent *** DONE Documentation [2/2] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential *** DONE Development [5/5] **** DONE Headers in -devel **** DONE If versioned .so's, unversioned in -devel **** N/A Static only if necessary, put in -static **** DONE -devel, -static requires main **** DONE No .la Great! Thank you! New Package CVS Request ======================= Package Name: libfc14audiodecoder Short Description: C wrapper library for Future Composer audio decoding Owners: mschwendt Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). |