Bug 606205 (halberd)
| Summary: | Review Request: halberd - Tool to discover HTTP load balancers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Rafael Aquini <aquini> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aquini, fedora-package-review, notting, pahan |
| Target Milestone: | --- | Flags: | aquini:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-01 10:25:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563471 | ||
|
Description
Fabian Affolter
2010-06-21 05:54:05 UTC
Fabian, I can review this package, if you still interested in take it off from the orphanage. Regards Good: * The package is named halberd which follows upstream project name * Spec file naming follows package naming * License in spec and sources is GPLv2+ which is open source * Spec is legible and American English * http://halberd.superadditive.com/dist/halberd-0.2.3.tar.gz * Source matches upstream * No locale files * No shared libraries * No bundled libraries * Not relocatable * No directories created unowned * No duplicate files * Default permissions are set * Package is code * No large documentation * No %doc files are used at runtime * No header files * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 * rpmlint is clean: [aquini@optiplex ~]$ rpmlint rpmbuild/SPECS/halberd.spec rpmbuild/SRPMS/halberd-0.2.3-2.fc13.src.rpm rpmbuild/RPMS/noarch/halberd-0.2.3-2.fc13.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. * Builds in mock * Builsd in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2387255 Needswork: * Ask upstream a patch to fix the following deprecation warning, when halberd is executed: [aquini@optiplex ~]$ halberd http://aquini.fedorapeople.org/ /usr/lib/python2.6/site-packages/Halberd/clues/Clue.py:33: DeprecationWarning: the sha module is deprecated; use the hashlib module instead from sha import new as hashfn halberd 0.2.3 (18-Jul-2007) INFO looking up host aquini.fedorapeople.org... Regards * Sat Aug 14 2010 Fabian Affolter <fabian> - 0.2.3-3 - Added patch to replace deprecated sha module Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/halberd.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/halberd-0.2.3-3.fc13.src.rpm Fabian, Your work in halberd is pretty fine, and I'm approving this package. However, I'd like ask you to consider the following suggestions before you commit halberd in git: i. There is another deprecation warning, when you shoot halberd against an https URL. Sorry for this late report... I've just noticed it today. Please, ask upstream for another patch to fix that also: /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330: DeprecationWarning: socket.ssl() is deprecated. Use ssl.wrap_socket() instead. ii. Consider include a comment to the patches in SPEC file, to inform the upstream's bugtracking number for them. APPROVED Thanks for the review. (In reply to comment #4) > i. There is another deprecation warning, when you shoot halberd against an > https URL. Sorry for this late report... I've just noticed it today. Please, > ask upstream for another patch to fix that also: > /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330: > DeprecationWarning: socket.ssl() is deprecated. Use ssl.wrap_socket() instead. Upstream applied my patch and released 0.2.4 some hours ago. I think that it would not be a problem to fix this issue upstream. > ii. Consider include a comment to the patches in SPEC file, to inform the > upstream's bugtracking number for them. There is no upstream tracker. Update CVS Request ======================= Owners: fab Branches: F-12 F-13 F-13 Branches: F-12 F-13 F-14 There already was a f12 branch. Added f13/f14. Note that you will probibly need to file a ticket with rel-eng to unblock it. Package Change Request ====================== Package Name: halberd New Branches: el6 epel7 Owners: fab InitialCC: Git done (by process-git-requests). |