Bug 607091
| Summary: | virt-install doesn't check for existing file before over-writing it as install image | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Jes Sorensen <Jes.Sorensen> |
| Component: | python-virtinst | Assignee: | Cole Robinson <crobinso> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 6.1 | CC: | dallan, dyuan, kxiong, mhideo, xen-maint, zpeng |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Unless the file image is already managed by libvirt, when a user specifies an existing file image with virt-install there is no warning displayed telling the user that the file will be overwritten. With this change the user is now prompted if the file already exists giving the user an opportunity to make any necessary corrections before overwriting the file image.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-19 13:45:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jes Sorensen
2010-06-23 07:51:56 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. This issue has been proposed when we are only considering blocker issues in the current Red Hat Enterprise Linux release. It has been denied for the current Red Hat Enterprise Linux release. ** If you would still like this issue considered for the current release, ask your support representative to file as a blocker on your behalf. Otherwise ask that it be considered for the next Red Hat Enterprise Linux release. ** Since it didn't make the 6.0 cute, please make sure to fix this before 6.1. It's a very annoying bug. Thanks, Jes Fixed upstream: http://hg.fedorahosted.org/hg/python-virtinst/rev/f10c74b09e80 $ ./virt-install --connect test:///default --prompt --name foo --ram 64 --pxe --hvm What would you like to use as the disk (file path)? README This will overwrite the existing path '/mnt/storage.bos/boston/crobinso/sandbox/upstream/python-virtinst/virtinst.upstream/README' Do you really want to use this disk (yes or no) no What would you like to use as the disk (file path)? Fix built in python-virtinst-0.500.5-1.el6 Verified with python-virtinst-0.500.5-1.el6 passed. 1.virt-install --connect test:///default --prompt --name foo --ram 64 --pxe --hvm 2.What would you like to use as the disk (file path)? /var/lib/libvirt/images/rhel55-i386.img This will overwrite the existing path '/var/lib/libvirt/images/rhel55-i386.img' Do you really want to use this disk (yes or no) no What would you like to use as the disk (file path)? So it will check the existing file before over-writing it. Verification is passed. verified this bug with: Linux localhost.localdomain 2.6.32-130.el6.x86_64 #1 SMP Tue Apr 5 19:58:31 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux python-virtinst-0.500.5-3.el6.noarch libvirt-0.8.7-17.el6.x86_64 passed.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
* Unless the file image is already managed by libvirt, when a user specifies an existing file image with virt-install there is no warning displayed telling the user that the file will be overwritten. With this change the user is now prompted if the file already exists giving the user an opportunity to make any necessary corrections before overwriting the file image. (BZ#607091)
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1 +1 @@
-* Unless the file image is already managed by libvirt, when a user specifies an existing file image with virt-install there is no warning displayed telling the user that the file will be overwritten. With this change the user is now prompted if the file already exists giving the user an opportunity to make any necessary corrections before overwriting the file image. (BZ#607091)+Unless the file image is already managed by libvirt, when a user specifies an existing file image with virt-install there is no warning displayed telling the user that the file will be overwritten. With this change the user is now prompted if the file already exists giving the user an opportunity to make any necessary corrections before overwriting the file image.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0636.html |