Bug 607223

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

(In reply to comment #0)
> Description of problem:
> 1. The initscript does not unload modules on stop.

This should only be case of the acpi_cpufreq module which cannot be removed once loaded.

> 
> 2. 'service cpuspeed reload' restarts the service
> 
> but the guidelines
> (https://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions) say:
> 
> "reload: reload the configuration of the service without actually stopping and
> restarting the service (if the service does not support this, do nothing)"
> 
> The configuration of cpuspeed is done via commandline parameters, to my best
> knowledge there is no method to ask the running daemon to reload the
> configuration. Thus 'reload' is not supported => should do nothing (fail with
> exit code 3, unimplemented feature).
> 
> But this is true just when using userspace governor and running the daemon. The
> reload, i.e. changing parameters without restarting, can be supported for other
> governors.
> 
> In addition, 'reload' on a stopped service should not start the service, which
> is exactly what happens if doing 'restart'.
> 

The init script now contains the reload() function which should behave with respect to the guidelines.

> 3. The initscript acts weird for p4-clockmod case - it refuses to stop. But
> trying manually, p4_clockmod module can be removed - see also above.
> 

The init script now stops the service.

> Version-Release number of selected component (if applicable):
> cpuspeed-1.5-13.el6    

cpuspeed-1.5-14.el6
https://brewweb.devel.redhat.com/taskinfo?taskID=2564890

Reproduced on cpuspeed-1.5-13.el6:

Problem with 'reload' action starting cpufreqd & problem with modules not unloading:
# service cpuspeed status
cpuspeed is stopped
# service cpuspeed reload

Enabling ondemand cpu frequency scaling:                   [  OK  ]
# /etc/init.d/cpuspeed status
Frequency scaling enabled using ondemand governor
# lsmod | grep cpufreq
cpufreq_ondemand        8454  4 
acpi_cpufreq            7384  1 
# /etc/init.d/cpuspeed stop
Disabling ondemand cpu frequency scaling:                  [  OK  ]
# lsmod | grep cpufreq
acpi_cpufreq            7384  1 

Problem with p4-clockmod:
# lsmod | grep p4_clockmod
p4_clockmod            20187  0 
freq_table              4847  1 p4_clockmod
speedstep_lib           5367  1 p4_clockmod
# service cpuspeed stop
p4-clockmod passive cooling support cannot be stopped
# lsmod | grep p4_clockmod
p4_clockmod            20187  0 
freq_table              4847  1 p4_clockmod
speedstep_lib           5367  1 p4_clockmod


Verified on cpuspeed-1.5-14.el6:

Problem with 'reload' action starting cpufreqd:
# service cpuspeed status
cpuspeed is stopped
# service cpuspeed reload
                                                           [FAILED]
# /etc/init.d/cpuspeed status
cpuspeed is stopped
# /etc/init.d/cpuspeed restart

Enabling ondemand cpu frequency scaling:                   [  OK  ]
# /etc/init.d/cpuspeed status
Frequency scaling enabled using ondemand governor

Problem with modules not unloading:
# /etc/init.d/cpuspeed status
Frequency scaling enabled using ondemand governor
# lsmod | grep cpufreq
cpufreq_ondemand        8454  4 
acpi_cpufreq            7384  1 
# /etc/init.d/cpuspeed stop
Disabling ondemand cpu frequency scaling:                  [  OK  ]
# lsmod | grep cpufreq
acpi_cpufreq            7384  1 

Problem with p4-clockmod:
# lsmod | grep p4_clockmod
p4_clockmod            20187  0 
freq_table              4847  1 p4_clockmod
speedstep_lib           5367  1 p4_clockmod
# service cpuspeed stop
p4-clockmod passive cooling support cannot be truly stopped
# lsmod | grep p4_clockmod
p4_clockmod            20187  0 
freq_table              4847  1 p4_clockmod
speedstep_lib           5367  1 p4_clockmod

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.