Bug 60906

Summary: X server will spin on the CPU and eventually crash if up for more than 49 days
Product: [Retired] Red Hat Linux Reporter: Christopher Blizzard <blizzard>
Component: XFree86Assignee: Mike A. Harris <mharris>
Status: CLOSED ERRATA QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2002-03-11 12:42:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch
none
patch from keith packard after sending mine for review none

Description Christopher Blizzard 2002-03-08 20:54:01 UTC
Description of Problem:


Version-Release number of selected component (if applicable):


How Reproducible:

Every time

Steps to Reproduce:
1. Set your clock to this date:

date 030701012002

2. Fire up the X server point it at a configured xdm server:

X -query foo

3. Set your date forward in time many days:

date 040402562002

Actual Results:

After a few minutes the X server will start hogging the CPU and will probably
crash or exit after a while with an error:

XDM: Too many retransmissions

Expected Results:

The X server should keep running as normal.

Additional Information:
	
It appears that after looking at the code that this bit of the code has a very
low tolerance for both clock skew, because someone changed the time, and when
the integer that holds the time rolls over its value.  It's very likely that the
retransmission times for contacting the xdm server will be fully screwed up.

I've got a patch that both adds support for detecting clock skew, and correcting
 from that condition, and handles the rollover of the value correctly.

Comment 1 Christopher Blizzard 2002-03-08 20:54:55 UTC
Created attachment 47940 [details]
patch

Comment 2 Mike A. Harris 2002-03-09 15:43:43 UTC
FIxed in rawhide, and also pending XFree86 erratum, will be released soon.

Comment 3 Christopher Blizzard 2002-03-09 17:48:23 UTC
What version of the XFree86 4.1.x rpms is this present in?

Comment 4 Mike A. Harris 2002-03-11 01:16:22 UTC
4.1.0-22

Comment 5 Christopher Blizzard 2002-03-11 12:42:26 UTC
Created attachment 48104 [details]
patch from keith packard after sending mine for review

Comment 6 Mike A. Harris 2002-03-11 13:29:21 UTC
Patch updated in 4.1.0-23