Bug 609164

Summary:	Review Request: xbean - Java plugin based server analogous to Eclipse being a plugin based IDE
Product:	[Fedora] Fedora	Reporter:	Stanislav Ochotnicky <sochotni>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lkundrak, notting
Target Milestone:	---	Flags:	lkundrak: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-07-13 08:42:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stanislav Ochotnicky 2010-06-29 14:46:54 UTC

Spec URL: http://sochotni.fedorapeople.org/xbean.spec
SRPM URL: http://sochotni.fedorapeople.org/xbean-3.7-1.fc13.src.rpm
Description: 
The goal of XBean project is to created a plugin based server
analogous to Eclipse being a plugin based IDE. XBean will be able to
discover, download and install server plugins from an Internet based
repository. In addition, we include support for multiple IoC systems,
support for running with no IoC system, JMX without JMX code,
lifecycle and class loader management, and a rock solid Spring
integration.

Koji build (dist-f14-maven221 tag)
https://koji.fedoraproject.org/koji/taskinfo?taskID=2280750

Comment 1 Lubomir Rintel 2010-07-09 08:42:49 UTC

* Package properly named
* SPEC file clean and legible
* License specified correctly, allowed in Fedora, included as a documentation file
* Builds fine in mock
* Filelist sane
* Requires/provides sane
* Rpmlint mostly happy

Fairly well done, APPROVED

Just one small remark:

Summary is completely non-obvious; you should state what does the package do, not what is it analogous to. Please adjust it.

Comment 2 Stanislav Ochotnicky 2010-07-09 11:54:01 UTC

Thanks for the review...I just noticed that this version wasn't compliant with recent changes to licensing guidelines (sub-packages are required to have LICENSE file of their own). I tried to fix the summary as well. 

Fixed up koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2308465

New Package CVS Request
=======================
Package Name: xbean
Short Description: Java plugin based web server
Owners: 
Branches: 
InitialCC:

Comment 3 Kevin Fenzi 2010-07-09 18:22:59 UTC

Can you add an owner here?

Comment 4 Stanislav Ochotnicky 2010-07-12 07:06:15 UTC

(In reply to comment #3)
> Can you add an owner here?    
Bad day I guess...

New Package CVS Request
=======================
Package Name: xbean
Short Description: Java plugin based web server
Owners: sochotni
Branches: 
InitialCC:

Comment 5 Kevin Fenzi 2010-07-12 17:23:46 UTC

CVS done (by process-cvs-requests.py).

Comment 6 Stanislav Ochotnicky 2010-07-13 08:42:09 UTC

Thanks all, closing.

Koji build:
https://koji.fedoraproject.org/koji/buildinfo?buildID=183370