Bug 609700

Summary: ceph : ceph : does not adhere to Static Library Packaging Guidelines
Product: [Fedora] Fedora Reporter: Michael Schwendt <bugs.michael>
Component: cephAssignee: Josef Bacik <josef>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: david, emailscottcollier, josef, tremble
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ceph-0.61.7-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-02 22:31:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 691033    

Description Michael Schwendt 2010-06-30 20:46:36 UTC
ceph-0.20-1.fc14.src
is missing
BuildRequires: libatomic_ops-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link against it provided that you BuildRequire the *-static subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.

Comment 1 Michael Schwendt 2010-07-01 10:27:36 UTC
Closed by: fedora-report-static-batch.py

Comment 2 Michael Schwendt 2010-07-01 10:48:16 UTC
Reason this got closed automatically:

 * Does ceph really need "BuildRequires: libatomic_ops-devel"?

The enabled koji build log checker suggests that it isn't needed, and a source grep for atomic_ops doesn't lead to anything either. Unneeded BuildRequires? rpmbuild --nodeps --rebuild succeeds, too. When was the BR needed and why?

Comment 3 Michael Schwendt 2010-10-05 13:38:48 UTC
Reopened by: fedora-report-static-batch.py

ceph-0.21.3-1.fc15.src
is missing
BuildRequires: libatomic_ops-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link against it provided that you BuildRequire the *-static subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.

Comment 4 Michael Schwendt 2010-10-05 13:42:24 UTC
Please see comment 2.

Comment 5 David Nalley 2011-11-06 01:56:59 UTC
libatomic_ops-devel is needed, though not -static.

Comment 6 Michael Schwendt 2011-11-06 10:09:36 UTC
It is a static-only lib, however. And therefore the guidelines apply. Reopening.

Comment 7 David Nalley 2011-11-09 17:03:39 UTC
(In reply to comment #6)
> It is a static-only lib, however. And therefore the guidelines apply.
> Reopening.

You are correct - I fixed this in the f16 branch, but haven't pushed a build (assuming there will be another version bump in a few weeks) 
I just kicked off a build in rawhide that resolves this issue. 

Thanks! 

--David

Comment 8 Michael Schwendt 2012-05-04 10:44:45 UTC
Reopened by: fedora-report-static-batch.py

ceph-0.45-2.fc18.src
is missing
BuildRequires: libatomic_ops-static

[...]

https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2

If a library you depend on only provides a static version your package can link against it provided that you BuildRequire the *-static subpackage. Packagers in such a situation should be aware that if a shared library becomes available, that you should adjust your package to use the shared library.

Comment 9 Michael Schwendt 2013-03-28 21:37:12 UTC
Dunno when or why, but somebody has removed "BuildRequires: libatomic_ops-static", and therefore this ticket is still open.

Comment 10 Fedora Update System 2013-04-01 15:32:10 UTC
ceph-0.56.4-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ceph-0.56.4-1.fc18

Comment 11 Michael Schwendt 2013-04-02 22:31:09 UTC
Closed by: fedora-report-static-batch.py
http://mschwendt.fedorapeople.org/staticbugstat.html

Comment 12 Fedora Update System 2013-07-30 17:55:58 UTC
ceph-0.61.7-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ceph-0.61.7-1.fc18

Comment 13 Fedora Update System 2013-09-06 04:01:14 UTC
ceph-0.61.7-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2013-09-06 05:22:47 UTC
ceph-0.61.7-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.