Bug 611080

Summary: Review Request: python-unittest2 - Backport of new unittest feature for Python 2.7 to Python 2.4+
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Martin Bacovsky <mbacovsk>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bkabrda, fedora-package-review, mbacovsk, metherid, notting
Target Milestone: ---Flags: mbacovsk: fedora-review+
opensource: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: NotReady
Fixed In Version: python-unittest2-0.5.1-1.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-26 00:55:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabian Affolter 2010-07-03 14:14:16 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2-0.1.4-1.fc13.src.rpm

Project URL: http://pypi.python.org/pypi/unittest2

Description:
unittest2 is a backport of the new features added to the unittest
testing framework in Python 2.7. It is tested to run on Python 2.4 - 
2.6.

To use unittest2 instead of unittest simply replace ``import unittest``
with ``import unittest2``.

Classes in unittest2 derive from the equivalent classes in unittest,
so it should be possible to use the unittest2 test running infra-
structure without having to switch all your tests to using unittest2
immediately. Similarly
you can use the new assert methods on ``unittest2.TestCase`` with the
standard unittest test running infrastructure. Not all of the new
features in unittest2 will work with the standard unittest test loaders
and runners however.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2292186

rpmlint output:
[fab@laptop011 SRPMS]$ rpmlint python-unittest2-0.1.4-1.fc13.src.rpm 
python-unittest2.src: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
python-unittest2.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python-unittest2.src: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
python-unittest2.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python-unittest2.src: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

[fab@laptop011 noarch]$ rpmlint python-unittest2-0.1.4-1.fc13.noarch.rpm 
python-unittest2.noarch: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
python-unittest2.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python-unittest2.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
python-unittest2.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python-unittest2.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
python-unittest2.noarch: W: no-manual-page-for-binary unit2
python-unittest2.noarch: W: no-manual-page-for-binary unit2.py
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

Comment 1 Martin Bacovsky 2010-07-12 13:04:24 UTC
The version 1.4.1 seems to be quite outdated.
Would you please update to 0.5.0 (http://pypi.python.org/packages/source/u/unittest2/unittest2-0.5.0.tar.gz#md5=24fb07f69bbd0da1c86b759fded839fd)?

Comment 2 Fabian Affolter 2010-07-15 18:46:49 UTC
(In reply to comment #1)
> The version 1.4.1 seems to be quite outdated.
> Would you please update to 0.5.0

Here are the updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-unittest2-0.5.0-1.fc13.src.rpm

Comment 3 Martin Bacovsky 2010-07-20 21:15:57 UTC
Thanks for the quick update

Comment 4 Martin Bacovsky 2010-07-20 22:53:32 UTC
There is already available 0.5.1 that I probably overlooked before, sorry for that. The update seems to remove unit2.py from %{_bindir}. Do you think it is worth one more update? Everything else is ok.

Comment 5 Fabian Affolter 2010-07-21 05:57:48 UTC
It's worth to update the package because we want the latest stuff in Fedora ;-)

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-unittest2-0.5.1-1.fc13.src.rpm

Comment 6 Martin Bacovsky 2010-07-21 07:25:21 UTC
Thanks,

 - = N/A
 x = OK
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Rpmlint output: 

    $ rpmlint python-unittest2-0.5.1-1.fc13.noarch.rpm 
    python-unittest2.noarch: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
    python-unittest2.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
    python-unittest2.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
    python-unittest2.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
    python-unittest2.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
    python-unittest2.noarch: E: zero-length /usr/lib/python2.6/site-packages/unittest2/test/dummy.py
    python-unittest2.noarch: W: no-manual-page-for-binary unit2-2.6
    python-unittest2.noarch: W: no-manual-page-for-binary unit2
    python-unittest2.noarch: W: no-manual-page-for-binary unit2.py
    1 packages and 0 specfiles checked; 1 errors, 8 warnings.
    
    The zero-length file is part of the library

    $ rpmlint python-unittest2-0.5.1-1.fc13.src.rpm 
    python-unittest2.src: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
    python-unittest2.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
    python-unittest2.src: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
    python-unittest2.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
    python-unittest2.src: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
    1 packages and 0 specfiles checked; 0 errors, 5 warnings.


 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: x86_64
     /var/lib/mock/fedora-13-x86_64/result

 [x] Package is not relocatable.
 [x] Buildroot is correct
     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: BSD

 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provideda in the spec URL.
     a0af5cac92bbbfa0c3b0e99571390e0f  unittest2-0.5.1.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.
 [x] All filenames in rpm packages must be valid UTF-8

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [?] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: f13.x86_64, f13.x86_64

 [-] Package should compile and build into binary rpms on all supporteda architectures.
     Tested on: rawhide.i386, rawhide.x86_64

 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass


ACCEPT

Comment 7 Fabian Affolter 2010-07-22 17:26:44 UTC
Thanks for the review, Martin.

Comment 8 Fabian Affolter 2010-07-22 17:27:18 UTC
New Package CVS Request
=======================
Package Name: python-unittest2
Short Description: Backport of new unittest feature for Python 2.7 to Python 2.4+
Owners: fab
Branches: F-12 F-13
InitialCC:

Comment 9 Martin Bacovsky 2010-07-23 13:25:37 UTC
Just curious, does it make sense to add this to devel when there is now python 2.7 there?

Comment 10 Kevin Fenzi 2010-07-23 21:39:17 UTC
CVS done (by process-cvs-requests.py).

Comment 11 Fedora Update System 2010-08-13 21:59:34 UTC
python-unittest2-0.5.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc13

Comment 12 Fedora Update System 2010-08-13 21:59:39 UTC
python-unittest2-0.5.1-1.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc14

Comment 13 Fedora Update System 2010-08-13 21:59:44 UTC
python-unittest2-0.5.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc12

Comment 14 Fedora Update System 2010-08-17 05:29:55 UTC
python-unittest2-0.5.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-unittest2'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc12

Comment 15 Fedora Update System 2010-08-26 00:55:21 UTC
python-unittest2-0.5.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2010-08-26 03:25:23 UTC
python-unittest2-0.5.1-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2010-09-04 04:53:53 UTC
python-unittest2-0.5.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Rahul Sundaram 2011-07-12 09:55:31 UTC
Package Change Request
======================
Package Name: python-unittest2
New Branches: el6
Owners: sundaram pjp
InitialCC:

Comment 19 Gwyn Ciesla 2011-07-12 12:40:16 UTC
Git done (by process-git-requests).

Comment 20 Bohuslav "Slavek" Kabrda 2014-11-10 10:23:36 UTC
Unretiring the package as per bug 1161166 comment 8. (If any of the original maintainers wants to comaintain, I'll be happy to accept :))

Package Change Request
======================
Package Name: python-unittest2
New Branches: devel
Owners: bkabrda

Comment 21 Gwyn Ciesla 2014-11-10 13:10:40 UTC
Complete.

Comment 22 Bohuslav "Slavek" Kabrda 2014-11-10 13:20:57 UTC
Ooops, I forgot to include the request for F21, too. I'm very sorry. Request for F21:


Package Change Request
======================
Package Name: python-unittest2
New Branches: f21
Owners: bkabrda

Comment 23 Gwyn Ciesla 2014-11-10 13:26:19 UTC
Complete.

Comment 24 Till Maas 2014-11-10 14:52:36 UTC
Package Change Request
======================
Package Name: python-unittest2
New Branches: f21
Owners: bkabrda

Comment 25 Till Maas 2014-11-10 14:59:00 UTC
Git done (by process-git-requests).

Comment 26 Till Maas 2014-11-10 17:00:22 UTC
The package was retired for more than two weeks, therefore a re-review is needed.