Bug 611080
| Summary: | Review Request: python-unittest2 - Backport of new unittest feature for Python 2.7 to Python 2.4+ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Martin Bacovsky <mbacovsk> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, fedora-package-review, mbacovsk, metherid, notting |
| Target Milestone: | --- | Flags: | mbacovsk:
fedora-review+
opensource: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | NotReady | ||
| Fixed In Version: | python-unittest2-0.5.1-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-26 00:55:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2010-07-03 14:14:16 UTC
The version 1.4.1 seems to be quite outdated. Would you please update to 0.5.0 (http://pypi.python.org/packages/source/u/unittest2/unittest2-0.5.0.tar.gz#md5=24fb07f69bbd0da1c86b759fded839fd)? (In reply to comment #1) > The version 1.4.1 seems to be quite outdated. > Would you please update to 0.5.0 Here are the updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2-0.5.0-1.fc13.src.rpm Thanks for the quick update There is already available 0.5.1 that I probably overlooked before, sorry for that. The update seems to remove unit2.py from %{_bindir}. Do you think it is worth one more update? Everything else is ok.
It's worth to update the package because we want the latest stuff in Fedora ;-) Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-unittest2-0.5.1-1.fc13.src.rpm Thanks,
- = N/A
x = OK
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Rpmlint output:
$ rpmlint python-unittest2-0.5.1-1.fc13.noarch.rpm
python-unittest2.noarch: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
python-unittest2.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python-unittest2.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
python-unittest2.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python-unittest2.noarch: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
python-unittest2.noarch: E: zero-length /usr/lib/python2.6/site-packages/unittest2/test/dummy.py
python-unittest2.noarch: W: no-manual-page-for-binary unit2-2.6
python-unittest2.noarch: W: no-manual-page-for-binary unit2
python-unittest2.noarch: W: no-manual-page-for-binary unit2.py
1 packages and 0 specfiles checked; 1 errors, 8 warnings.
The zero-length file is part of the library
$ rpmlint python-unittest2-0.5.1-1.fc13.src.rpm
python-unittest2.src: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backplate
python-unittest2.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python-unittest2.src: W: spelling-error %description -l en_US backport -> back port, back-port, backplate
python-unittest2.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python-unittest2.src: W: spelling-error %description -l en_US TestCase -> Test Case, Test-Case, Test-case
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
Tested on: x86_64
/var/lib/mock/fedora-13-x86_64/result
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: BSD
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provideda in the spec URL.
a0af5cac92bbbfa0c3b0e99571390e0f unittest2-0.5.1.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x] Package does not own files or directories owned by other packages.
[x] All filenames in rpm packages must be valid UTF-8
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[?] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: f13.x86_64, f13.x86_64
[-] Package should compile and build into binary rpms on all supporteda architectures.
Tested on: rawhide.i386, rawhide.x86_64
[x] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
ACCEPT
Thanks for the review, Martin. New Package CVS Request ======================= Package Name: python-unittest2 Short Description: Backport of new unittest feature for Python 2.7 to Python 2.4+ Owners: fab Branches: F-12 F-13 InitialCC: Just curious, does it make sense to add this to devel when there is now python 2.7 there? CVS done (by process-cvs-requests.py). python-unittest2-0.5.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc13 python-unittest2-0.5.1-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc14 python-unittest2-0.5.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc12 python-unittest2-0.5.1-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-unittest2'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-unittest2-0.5.1-1.fc12 python-unittest2-0.5.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. python-unittest2-0.5.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. python-unittest2-0.5.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-unittest2 New Branches: el6 Owners: sundaram pjp InitialCC: Git done (by process-git-requests). Unretiring the package as per bug 1161166 comment 8. (If any of the original maintainers wants to comaintain, I'll be happy to accept :)) Package Change Request ====================== Package Name: python-unittest2 New Branches: devel Owners: bkabrda Complete. Ooops, I forgot to include the request for F21, too. I'm very sorry. Request for F21: Package Change Request ====================== Package Name: python-unittest2 New Branches: f21 Owners: bkabrda Complete. Package Change Request ====================== Package Name: python-unittest2 New Branches: f21 Owners: bkabrda Git done (by process-git-requests). The package was retired for more than two weeks, therefore a re-review is needed. |